Skip to content

[test] Avoid reusing a.mjs for all js tests.#7534

Merged
sbc100 merged 1 commit into
mainfrom
js_tests
Apr 21, 2025
Merged

[test] Avoid reusing a.mjs for all js tests.#7534
sbc100 merged 1 commit into
mainfrom
js_tests

Conversation

@sbc100
Copy link
Copy Markdown
Member

@sbc100 sbc100 commented Apr 21, 2025

Instead create <filename>.mjs named after each test.

Test output now looks like this:

$ ./check.py --binaryen-bin=emcc-build/bin binaryenjs_wasm
warning: Binaryen not found (or has not been successfully built to bin/ ?
executing:  /usr/bin/node -e process.stdout.write(typeof WebAssembly)

[ checking binaryen.js testcases (/usr/local/google/home/sbc/dev/wasm/binaryen/emcc-build/bin/binaryen_wasm.js)... ]

executing:  /usr/bin/node atomics.mjs
executing:  /usr/bin/node closed-world.mjs
executing:  /usr/bin/node copy-expression.mjs
executing:  /usr/bin/node custom-section.mjs
...

Previously:

$ ./check.py --binaryen-bin=emcc-build/bin binaryenjs_wasm
warning: Binaryen not found (or has not been successfully built to bin/ ?
executing:  /usr/bin/node -e process.stdout.write(typeof WebAssembly)

[ checking binaryen.js testcases (/usr/local/google/home/sbc/dev/wasm/binaryen/emcc-build/bin/binaryen_wasm.js)... ]

atomics.js
executing:  /usr/bin/node a.mjs
closed-world.js
executing:  /usr/bin/node a.mjs
copy-expression.js
executing:  /usr/bin/node a.mjs
custom-section.js
executing:  /usr/bin/node a.mjs
debug-info.js
executing:  /usr/bin/node a.mjs
debug-names.js
executing:  /usr/bin/node a.mjs
emit_asmjs.js
...

Instead create `<filename>.mjs` named after each test.
@sbc100 sbc100 enabled auto-merge (squash) April 21, 2025 18:26
@sbc100 sbc100 disabled auto-merge April 21, 2025 19:05
@sbc100 sbc100 merged commit 27fbd31 into main Apr 21, 2025
14 checks passed
@sbc100 sbc100 deleted the js_tests branch April 21, 2025 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants