feat(antd-java,antd-cpp): close async client surface gaps - #133
Merged
Conversation
antd-java AsyncAntdClient was missing async counterparts for wallet operations and the external-signer prepare/finalize family — a consumer who picked AsyncAntdClient silently lost access to those methods with no compile-time signal. antd-cpp AsyncClient had the same gap. Adds 9 async methods to antd-java AsyncAntdClient.java (truly non-blocking via doJsonAsync, mirroring the existing pattern): walletAddressAsync, walletBalanceAsync, walletApproveAsync, prepareUploadAsync (overload), prepareUploadPublicAsync, prepareDataUploadAsync, finalizeUploadAsync, finalizeMerkleUploadAsync Adds 8 async methods to antd-cpp AsyncClient (std::async dispatch to the sync Client, mirroring the existing pattern): wallet_address, wallet_balance, wallet_approve, prepare_upload, prepare_upload_public, prepare_data_upload, finalize_upload, finalize_merkle_upload AntdClient parsePrepareResponse + parseFinalizeUploadResult widened from private to package-private so AsyncAntdClient can reuse them via method references (matches the existing parseHealthStatus + parsePrepareChunkResult visibility). New test files cover all async methods (existing 11 + new 9 in java; existing 13 + new 8 in cpp). Previous async methods had zero test coverage in either SDK — now both surfaces have round-trip smoke tests against an in-process mock daemon, plus error-propagation tests. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Nic-dorman
added a commit
that referenced
this pull request
May 28, 2026
Closes the gRPC parity gap with REST: external-signer (UploadService + chunks PrepareChunk/FinalizeChunk) and WalletService are now reachable over gRPC, plus stream-download stubs return honest UNIMPLEMENTED/501 instead of pretending. All 11 gRPC-capable SDKs follow with matching fan-out. ## Additive (antd daemon) - gRPC UploadService + chunks prepare/finalize — external-signer two-phase upload + single-chunk publish over gRPC, mirroring REST 1:1 (#140) - gRPC WalletService — GetAddress / GetBalance / Approve, parity with REST /v1/wallet/* (#154) - /v1/data/prepare now honors visibility for public DataMap chunk bundling via data_prepare_upload_with_visibility (#138) ## Fixes (antd daemon) - Stream-download stubs (DataServiceStub.StreamDownload, REST /v1/data/stream/*) now return UNIMPLEMENTED / 501 honestly rather than empty success (#155) ## SDK fan-out — external-signer (gRPC prepare/finalize) All 11 gRPC-capable SDKs replace their stub raises with real gRPC calls to the new UploadService + ChunkService PrepareChunk/FinalizeChunk RPCs: - antd-rust (#169), antd-go (#170), antd-py (#171), antd-java (#172), antd-kotlin (#173), antd-csharp (#174), antd-ruby (#175), antd-dart (#176), antd-swift (#177), antd-cpp (#178), antd-elixir (#179) ## SDK fan-out — WalletService Same 11 SDKs gain walletAddress / walletBalance / walletApprove over gRPC: - antd-rust (#180), antd-go (#181), antd-py (#182), antd-java (#183), antd-kotlin (#184), antd-csharp (#185), antd-ruby (#186), antd-dart (#187), antd-swift (#188), antd-cpp (#189), antd-elixir (#190) ## SDK examples + build fixes - antd-ruby: payForQuotes tuple args as Hash for eth-0.5.13 compatibility (#131) - antd-go + ant-dev: add 03-chunks + 06-private-data examples; renumber 03-files to 04-files (#132) - antd-java + antd-cpp: close async client surface gaps (#133) - ant-dev: pull antd[rest,grpc] extras so 08_grpc example runs out of the box (#134) - antd-js + antd-py + antd-go READMEs: surface external-signer methods + 07 example (#135) - antd-elixir: 07_external_signer example via cast shell-out (#136) - antd-swift: 07_external_signer example + fix FinalizeUploadDTO optional address (#137) - antd-php: empty tx_hashes serializes as JSON object on finalize (#139) ## FFI - ant-ffi refresh against current ant-core API + Swift xcframework build pipeline (#150) - Android AAR build pipeline (#156) ## Infra - CI: auto-tag Go submodules on umbrella release tag push (#129) - Deploy: publish multi-arch withautonomi/antd image from ant-sdk release (#130) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes long-standing surface drift between sync and async clients on antd-java and antd-cpp. A consumer who picked the async client today silently lost access to the wallet ops + external-signer prepare/finalize family — no compile-time signal, the methods just didn't exist.
antd-java — 9 new async methods (truly non-blocking via
HttpClient.sendAsync)walletAddressAsync,walletBalanceAsync,walletApproveAsync,prepareUploadAsync(single-arg + visibility overload),prepareUploadPublicAsync,prepareDataUploadAsync,finalizeUploadAsync,finalizeMerkleUploadAsync.antd-cpp — 8 new async methods (
std::asyncdispatch to syncClient)wallet_address,wallet_balance,wallet_approve,prepare_upload,prepare_upload_public,prepare_data_upload,finalize_upload,finalize_merkle_upload.Parse-helper visibility tweak
AntdClient.parsePrepareResponseandAntdClient.parseFinalizeUploadResultwidened fromprivateto package-privatestaticsoAsyncAntdClientcan reuse them via method references — matches the existing visibility ofparseHealthStatusandparsePrepareChunkResult.Tests
Both SDKs had zero async test coverage before this change (the 2 existing async methods on each were untested). New test files give the full async surface round-trip smoke coverage plus error-propagation tests:
antd-java/src/test/java/com/autonomi/antd/AsyncAntdClientTest.java— 24 tests covering all async methods + 404 propagationantd-cpp/tests/test_async_client.cpp— 18 doctest cases covering all async methods + connection-error propagation (registered inCMakeLists.txtasantd_async_tests)Test plan
./gradlew test— BUILD SUCCESSFUL (full java suite)ctest --output-on-failure— 3/3 passed (antd_tests, antd_async_tests, antd_grpc_tests)doJsonAsync(...).thenApply(...)pattern; cpp async impls follow existingstd::async(std::launch::async, [this, ...]{ return client_.foo(...); })pattern🤖 Generated with Claude Code