docs: surface external-signer methods + 07 example in antd-js/py/go READMEs - #135
Merged
Merged
Conversation
…EADMEs The external-signer surface (prepare_*/finalize_*) and the 07_external_signer example have been in the SDK code since the put/get rename landed but the READMEs in antd-js, antd-py, and antd-go did not reflect them — a v1.0 consumer reading the README to discover the surface would never see the external-signer flow. Adds: - New "External Signer" section in each README's API Reference covering prepare_upload / prepare_upload_public / prepare_data_upload / prepare_chunk_upload / finalize_upload (+ FinalizeMerkleUpload for go) / finalize_chunk_upload - 07-external-signer entry in each README's examples list (also bumps the antd-js count from 6 to 7, and adds 08_grpc to antd-py's list) antd-go README also picks up a renumber correction: the examples block still listed 03-files which is now 04-files, and was missing 03-chunks + 06-private-data + 07-external-signer. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Nic-dorman
added a commit
that referenced
this pull request
May 28, 2026
Closes the gRPC parity gap with REST: external-signer (UploadService + chunks PrepareChunk/FinalizeChunk) and WalletService are now reachable over gRPC, plus stream-download stubs return honest UNIMPLEMENTED/501 instead of pretending. All 11 gRPC-capable SDKs follow with matching fan-out. ## Additive (antd daemon) - gRPC UploadService + chunks prepare/finalize — external-signer two-phase upload + single-chunk publish over gRPC, mirroring REST 1:1 (#140) - gRPC WalletService — GetAddress / GetBalance / Approve, parity with REST /v1/wallet/* (#154) - /v1/data/prepare now honors visibility for public DataMap chunk bundling via data_prepare_upload_with_visibility (#138) ## Fixes (antd daemon) - Stream-download stubs (DataServiceStub.StreamDownload, REST /v1/data/stream/*) now return UNIMPLEMENTED / 501 honestly rather than empty success (#155) ## SDK fan-out — external-signer (gRPC prepare/finalize) All 11 gRPC-capable SDKs replace their stub raises with real gRPC calls to the new UploadService + ChunkService PrepareChunk/FinalizeChunk RPCs: - antd-rust (#169), antd-go (#170), antd-py (#171), antd-java (#172), antd-kotlin (#173), antd-csharp (#174), antd-ruby (#175), antd-dart (#176), antd-swift (#177), antd-cpp (#178), antd-elixir (#179) ## SDK fan-out — WalletService Same 11 SDKs gain walletAddress / walletBalance / walletApprove over gRPC: - antd-rust (#180), antd-go (#181), antd-py (#182), antd-java (#183), antd-kotlin (#184), antd-csharp (#185), antd-ruby (#186), antd-dart (#187), antd-swift (#188), antd-cpp (#189), antd-elixir (#190) ## SDK examples + build fixes - antd-ruby: payForQuotes tuple args as Hash for eth-0.5.13 compatibility (#131) - antd-go + ant-dev: add 03-chunks + 06-private-data examples; renumber 03-files to 04-files (#132) - antd-java + antd-cpp: close async client surface gaps (#133) - ant-dev: pull antd[rest,grpc] extras so 08_grpc example runs out of the box (#134) - antd-js + antd-py + antd-go READMEs: surface external-signer methods + 07 example (#135) - antd-elixir: 07_external_signer example via cast shell-out (#136) - antd-swift: 07_external_signer example + fix FinalizeUploadDTO optional address (#137) - antd-php: empty tx_hashes serializes as JSON object on finalize (#139) ## FFI - ant-ffi refresh against current ant-core API + Swift xcframework build pipeline (#150) - Android AAR build pipeline (#156) ## Infra - CI: auto-tag Go submodules on umbrella release tag push (#129) - Deploy: publish multi-arch withautonomi/antd image from ant-sdk release (#130) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The external-signer surface (
prepare_*/finalize_*) has been in the SDK code since the put/get rename, but antd-js, antd-py, and antd-go READMEs never picked up the docs — so a v1.0 consumer reading any of those READMEs wouldn't discover the flow.Adds in each README:
prepare_upload/prepare_upload_public/prepare_data_upload/prepare_chunk_upload/finalize_upload/finalize_chunk_upload(+FinalizeMerkleUploadfor go which has it exposed)07-external-signerentry in the examples list (also bumps antd-js's "6 runnable scripts" → 7 and adds08_grpc.pyto antd-py)antd-go README also picks up a renumber correction: the examples block still listed
03-fileswhich is now04-files(per PR #132), and was missing03-chunks+06-private-data+07-external-signer.Test plan
🤖 Generated with Claude Code