fix: prevent silent data loss in batch processing loops#2
Open
Abzaek wants to merge 2 commits into
Open
Conversation
- batch_import_locations.py: append item BEFORE checking if batch is full. Previously, every Nth item was flushed-around and never appended — causing silent data loss (e.g. item #100, #200, ...). - woosmap_to_woosmap.py: same fix for store batch processing (every 500th store was lost). - woosmap_to_woosmap.py: replace except BaseException with except Exception to allow KeyboardInterrupt/SystemExit to propagate.
- batch_import_locations.py: append item BEFORE checking if batch is full. Previously, every (batch_size+1)th item was flushed without being appended — e.g. items #101, #202, #303 silently lost. - woosmap_to_woosmap.py: same fix (every 501st store was lost). - woosmap_to_woosmap.py: replace two except BaseException with except Exception to allow KeyboardInterrupt/SystemExit to propagate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
batch_import_locations.py, items at positionbatch_size + 1were silently dropped (e.g. #101, #202, #303). The batch-flush branch ran before appending the current item, so when the batch hit capacity the item was flushed-around and never added.Same bug in
woosmap_to_woosmap.py— every 501st store was lost.Also replaces two
except BaseExceptionwithexcept Exceptionto allow KeyboardInterrupt/SystemExit to propagate.Fix
Append item first, then check if the batch is full and flush.