Skip to content

fix: prevent silent data loss in batch processing loops #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abzaek wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: prevent silent data loss in batch processing loops #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
33c8284
fix: prevent silent data loss in batch processing loops
Abzaek May 16, 2026
d19cfa7
fix: prevent silent data loss in batch processing loops
Abzaek May 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions python-samples/batchimport/batch_import_locations.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,11 +101,10 @@ def import_batch(batch, use_put=False):
try:
woosmap_location = datagov2woosmap(location, "ID" + str(id))

batch.append(woosmap_location)
if len(batch) == batch_size:
batch_result = import_batch(batch, use_put=update_location)
batch = []
else:
batch.append(woosmap_location)

except InvalidGeometry:
pass
Expand Down
11 changes: 5 additions & 6 deletions python-samples/woosmap_to_woosmap/woosmap_to_woosmap.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@ def transform_geojson_woosmap(extracted_geojson):
"name": prop.get("name", ""),
"tags": prop.get("tags", []),
"contact": prop.get("contact", {})})
except BaseException as error:
print('An exception occurred: {}'.format(error))
except Exception as err:
print('An exception occurred: {}'.format(err))

return stores

Expand Down Expand Up @@ -90,15 +90,14 @@ def import_location(locations):
export_input_json(stores_woosmap)
if private_key:
for store in stores_woosmap:
batch.append(store)
if len(batch) == stores_batch_size:
batch_result = import_location(batch)
batch = []
else:
batch.append(store)

if batch:
batch_result = import_location(batch)
batch = []

except BaseException as error: # bad bad way!
print('An exception occurred: {}'.format(error))
except Exception as err:
print('An exception occurred: {}'.format(err))