Skip to content

sync: port upstream composer image upload wire format (#4035)#162

Merged
aaditagrawal merged 1 commit into
mainfrom
sync/20260717-composer-images
Jul 17, 2026
Merged

sync: port upstream composer image upload wire format (#4035)#162
aaditagrawal merged 1 commit into
mainfrom
sync/20260717-composer-images

Conversation

@aaditagrawal

@aaditagrawal aaditagrawal commented Jul 17, 2026

Copy link
Copy Markdown
Owner

What changed

  • Ports upstream #4035: send composer images in upload wire format (toUploadChatImageAttachments) from mobile startTurn and outbox drain.
  • Preserves fork: n/a (narrow mobile wire-format strip).

Validation

  • composerImages.test.ts 4/4 passed in port worktree
  • Tip stack: vp check and vp run typecheck passed

Stack: 3 of 6; depends on #161.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@aaditagrawal, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 53cb20cb-7c53-4b3f-b379-2102384a99c7

📥 Commits

Reviewing files that changed from the base of the PR and between b3275dc and d2ae0d8.

📒 Files selected for processing (4)
  • apps/mobile/src/lib/composerImages.test.ts
  • apps/mobile/src/lib/composerImages.ts
  • apps/mobile/src/lib/projectThreadStartTurn.ts
  • apps/mobile/src/state/use-thread-outbox-drain.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/20260717-composer-images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@aaditagrawal

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@aaditagrawal
aaditagrawal force-pushed the sync/20260717-composer-images branch from e1784f1 to 60a649c Compare July 17, 2026 10:37
@aaditagrawal
aaditagrawal force-pushed the sync/20260717-ws-snapshot branch 2 times, most recently from 201c863 to 9821428 Compare July 17, 2026 10:38
@aaditagrawal
aaditagrawal force-pushed the sync/20260717-composer-images branch from 60a649c to 0c3f54b Compare July 17, 2026 10:38

aaditagrawal commented Jul 17, 2026

Copy link
Copy Markdown
Owner Author

Merge activity

  • Jul 17, 10:56 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 17, 11:00 AM UTC: Graphite rebased this pull request as part of a merge.
  • Jul 17, 11:00 AM UTC: @aaditagrawal merged this pull request with Graphite.

@aaditagrawal
aaditagrawal changed the base branch from sync/20260717-ws-snapshot to graphite-base/162 July 17, 2026 10:57
@aaditagrawal
aaditagrawal changed the base branch from graphite-base/162 to main July 17, 2026 10:58
@aaditagrawal
aaditagrawal force-pushed the sync/20260717-composer-images branch from 0c3f54b to d2ae0d8 Compare July 17, 2026 10:59
@aaditagrawal
aaditagrawal merged commit 37aa437 into main Jul 17, 2026
12 checks passed
aaditagrawal added a commit that referenced this pull request Jul 17, 2026
#163)

## What changed

- Ports upstream `pingdotgg#4043`: iOS terminal Enter/Return normalized to CR (`\r`); hardware key revision bumped to 3.
- Preserves fork: Android terminal hardware-key path unchanged.

## Validation

- Mobile typecheck passed in port worktree; tip stack `vp check` / `vp run typecheck` passed
- `vp run lint:mobile` blocked locally by SourceKit/`swiftlint` environment (pre-existing)

Stack: 4 of 6; depends on #162.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S 10-29 effective changed lines (test files excluded in mixed PRs). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant