sync: port upstream real-route app store screenshot harness (#4014) - #165
Conversation
|
Warning Review limit reached
Next review available in: 9 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (39)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:trusted
|
@coderabbitai review |
✅ Action performedReview finished.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dee36cf808
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dee36cf to
cc166ef
Compare
4fab015 to
d854de6
Compare
cc166ef to
54f392d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54f392db00
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| host: string, | ||
| config: ShowcaseConfig, | ||
| ): Promise<void> { | ||
| const url = `http://${host}:${config.metroPort}/apps/mobile/index.bundle?platform=${platform}&dev=true&minify=false`; |
There was a problem hiding this comment.
For every normal capture where --skip-metro is not passed, startMetro launches Expo with cwd: MOBILE_ROOT, and apps/mobile/metro.config.js keeps apps/mobile as Metro's project root. Requesting /apps/mobile/index.bundle therefore resolves an entry beneath apps/mobile/apps/mobile/ rather than the real apps/mobile/index.ts; curl --fail aborts the harness during bundle warming before any build or capture runs. Request /index.bundle here, or explicitly configure Metro with the repository root.
Useful? React with 👍 / 👎.
| export function resolveShowcaseAndroidAbi( | ||
| value: string | undefined, | ||
| ): NonNullable<ShowcaseAndroidDevice["abi"]> { | ||
| if (!value) return "arm64-v8a"; |
There was a problem hiding this comment.
When an Intel Mac or local x86_64 Linux developer runs the documented Android command without setting T3_SHOWCASE_ANDROID_ABI, this always selects arm64-v8a; buildAndroid then passes that as the only reactNativeArchitectures value even when Pixel_10_Pro is an x86_64 AVD, leaving the APK without compatible native libraries. CI avoids the failure only because its workflow explicitly overrides the variable. Default according to process.arch (or inspect the configured AVD), while retaining the environment override.
Useful? React with 👍 / 👎.
Merge activity
|
Gate ShowcaseCaptureCoordinator behind EXPO_PUBLIC_SHOWCASE, align terminal history seeding with historyPath, fully decode PNGs during validate-only, and reissue one-time pairing grants on iOS launch retries.
54f392d to
8a57e8b
Compare
1 participant
What changed
#4014: real-route app store screenshot harness (showcase coordinator, scripts, workflow, native autoFocus hooks, docs).sync:upstream-prsscript, Android hardwareKeyRevision 3.Validation
vp check+vp run typecheckpassed afterpnpm install(pngjs)upstream/mainis content-empty vs this tip (will record on trunk after stack merges)Stack: 6 of 6; depends on #164.