Skip to content

Hearing - Use class EH instead of extended EH#9986

Merged
johnb432 merged 1 commit intomasterfrom
hearing-use-classEH
Apr 28, 2024
Merged

Hearing - Use class EH instead of extended EH#9986
johnb432 merged 1 commit intomasterfrom
hearing-use-classEH

Conversation

@johnb432
Copy link
Copy Markdown
Contributor

When merged this pull request will:

  • Title.
  • Means that FUNC(addEarPlugs) isn't called every time a unit is placed if hearing is off.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@johnb432 johnb432 added kind/optimization Release Notes: **IMPROVED:** ignore-changelog Release Notes: Excluded labels Apr 28, 2024
@johnb432 johnb432 merged commit 3b80629 into master Apr 28, 2024
@johnb432 johnb432 deleted the hearing-use-classEH branch April 28, 2024 16:02
@johnb432 johnb432 added this to the 3.17.1 milestone Apr 28, 2024
@johnb432
Copy link
Copy Markdown
Contributor Author

Can be moved to 3.18.0 if wanted.

@jonpas
Copy link
Copy Markdown
Member

jonpas commented Apr 29, 2024

Why is this ignore-changelog?

@johnb432
Copy link
Copy Markdown
Contributor Author

It doesn't change the behaviour.

@jonpas
Copy link
Copy Markdown
Member

jonpas commented Apr 29, 2024

It's still an optimization.

@jonpas jonpas removed the ignore-changelog Release Notes: Excluded label Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/optimization Release Notes: **IMPROVED:**

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants