Skip to content

Explicitly import crypto#1842

Merged
joshmgross merged 5 commits intomainfrom
joshmgross/explicit-import-crypto
Oct 4, 2024
Merged

Explicitly import crypto#1842
joshmgross merged 5 commits intomainfrom
joshmgross/explicit-import-crypto

Conversation

@joshmgross
Copy link
Copy Markdown
Contributor

@joshmgross joshmgross commented Oct 4, 2024

#1841

crypto has to be explicitly imported in versions before Node 19, so #1824 broke using these packages.

I've validated that importing crypto works as expected on Node 16, 18, and 20:

#1841 (comment)

@joshmgross joshmgross requested review from a team as code owners October 4, 2024 20:00
@reemasardana
Copy link
Copy Markdown

reemasardana commented Oct 4, 2024

I've validated that importing crypto works as expected on Node 16, 18, and 20:

Were these manual tests? Anything we can easily automate to prevent future accidental breakages like this?

@joshmgross joshmgross mentioned this pull request Oct 4, 2024
Merged
@joshmgross
Copy link
Copy Markdown
Contributor Author

joshmgross commented Oct 4, 2024

I've validated that importing crypto works as expected on Node 16, 18, and 20:

Were these manual tests? Anything we can easily automate to prevent future accidental breakages like this?

We can run tests against other Node versions besides the current support action Node version. I've validated that this catches the issue described in #1841 - #1843.

In the future we should be clear about what Node versions we support for the toolkit, but until then I think it's reasonable to validate that the toolkit at least works with what users currently expect.

@joshmgross joshmgross merged commit d14afd7 into main Oct 4, 2024
@joshmgross joshmgross deleted the joshmgross/explicit-import-crypto branch October 4, 2024 21:23
zemnmez-renovate-bot added a commit to zemn-me/monorepo that referenced this pull request Oct 4, 2024
@zemnmez-renovate-bot
chore(deps): update dependency @actions/core to v1.11.1
82658ed 
##### [`v1.11.1](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1111)

-   Fix uses of `crypto.randomUUID` on Node 18 and earlier [#1842](actions/toolkit#1842)
github-merge-queue Bot pushed a commit to zemn-me/monorepo that referenced this pull request Oct 4, 2024
@zemnmez-renovate-bot
chore(deps): update dependency @actions/core to v1.11.1
4a7f139 
##### [`v1.11.1](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1111)

-   Fix uses of `crypto.randomUUID` on Node 18 and earlier [#1842](actions/toolkit#1842)
@joshmgross joshmgross mentioned this pull request Oct 21, 2024
Merged
chhe pushed a commit to chhe/act_runner that referenced this pull request May 1, 2026
@bircni
chore(deps): update dependency @actions/core to v1.11.1 (#880)
b1c873a 
This PR contains the following updates:

| Package | Change | [Age](https://docs.renovatebot.com/merge-confidence/) | [Confidence](https://docs.renovatebot.com/merge-confidence/) |
|---|---|---|---|
| [@actions/core](https://github.com/actions/toolkit/tree/main/packages/core) ([source](https://github.com/actions/toolkit/tree/HEAD/packages/core)) | [`1.10.0` → `1.11.1`](https://renovatebot.com/diffs/npm/@actions%2fcore/1.10.0/1.11.1) | ![age](https://developer.mend.io/api/mc/badges/age/npm/@actions%2fcore/1.11.1?slim=true) | ![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@actions%2fcore/1.10.0/1.11.1?slim=true) |

---

### Release Notes

<details>
<summary>actions/toolkit (@&#8203;actions/core)</summary>

### [`v1.11.1`](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1111)

- Fix uses of `crypto.randomUUID` on Node 18 and earlier [#&#8203;1842](actions/toolkit#1842)

##### 1.11.0

- Add platform info utilities [#&#8203;1551](actions/toolkit#1551)
- Remove dependency on `uuid` package [#&#8203;1824](actions/toolkit#1824)

##### 1.10.1

- Fix error message reference in oidc utils [#&#8203;1511](actions/toolkit#1511)

##### 1.10.0

- `saveState` and `setOutput` now use environment files if available [#&#8203;1178](actions/toolkit#1178)
- `getMultilineInput` now correctly trims whitespace by default [#&#8203;1185](actions/toolkit#1185)

##### 1.9.1

- Randomize delimiter when calling `core.exportVariable`

##### 1.9.0

- Added `toPosixPath`, `toWin32Path` and `toPlatformPath` utilities [#&#8203;1102](actions/toolkit#1102)

##### 1.8.2

- Update to v2.0.1 of `@actions/http-client` [#&#8203;1087](actions/toolkit#1087)

##### 1.8.1

- Update to v2.0.0 of `@actions/http-client`

##### 1.8.0

- Deprecate `markdownSummary` extension export in favor of `summary`
  - [#&#8203;1072](actions/toolkit#1072)
  - [#&#8203;1073](actions/toolkit#1073)

##### 1.7.0

- [Added `markdownSummary` extension](actions/toolkit#1014)

##### 1.6.0

- [Added OIDC Client function `getIDToken`](actions/toolkit#919)
- [Added `file` parameter to `AnnotationProperties`](actions/toolkit#896)

##### 1.5.0

- [Added support for notice annotations and more annotation fields](actions/toolkit#855)

##### 1.4.0

- [Added the `getMultilineInput` function](actions/toolkit#829)

##### 1.3.0

- [Added the trimWhitespace option to getInput](actions/toolkit#802)
- [Added the getBooleanInput function](actions/toolkit#725)

##### 1.2.7

- [Prepend newline for set-output](actions/toolkit#772)

##### 1.2.6

- [Update `exportVariable` and `addPath` to use environment files](actions/toolkit#571)

##### 1.2.5

- [Correctly bundle License File with package](actions/toolkit#548)

##### 1.2.4

- [Be more lenient in accepting non-string command inputs](actions/toolkit#405)
- [Add Echo commands](actions/toolkit#411)

##### 1.2.3

- [IsDebug logging](README.md#logging)

##### 1.2.2

- [Fix escaping for runner commands](actions/toolkit#302)

##### 1.2.1

- [Remove trailing comma from commands](actions/toolkit#263)
- [Add "types" to package.json](actions/toolkit#221)

##### 1.2.0

- saveState and getState functions for wrapper tasks (on finally entry points that run post job)

##### 1.1.3

- setSecret added to register a secret with the runner to be masked from the logs
- exportSecret which was not implemented and never worked was removed after clarification from product.

##### 1.1.1

- Add support for action input variables with multiple spaces [#&#8203;127](actions/toolkit#127)
- Switched ## commands to :: commands (should have no noticeable impact) \[[#&#8203;110](https://github.com/actions/toolkit/issues/110))([#&#8203;110](https://github.com/actions/toolkit/pull/110))

##### 1.1.0

- Added helpers for `group` and `endgroup` [#&#8203;98](actions/toolkit#98)

##### 1.0.0

- Initial release

### [`v1.11.0`](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1110)

- Add platform info utilities [#&#8203;1551](actions/toolkit#1551)
- Remove dependency on `uuid` package [#&#8203;1824](actions/toolkit#1824)

### [`v1.10.1`](https://github.com/actions/toolkit/blob/HEAD/packages/core/RELEASES.md#1101)

- Fix error message reference in oidc utils [#&#8203;1511](actions/toolkit#1511)

</details>

---

### Configuration

📅 **Schedule**: (UTC)

- Branch creation
  - At any time (no schedule defined)
- Automerge
  - At any time (no schedule defined)

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xNTAuMCIsInVwZGF0ZWRJblZlciI6IjQzLjE1MC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119-->

Reviewed-on: https://gitea.com/gitea/runner/pulls/880
Reviewed-by: Nicolas <bircni@icloud.com>
Co-authored-by: Renovate Bot <renovate-bot@gitea.com>
Co-committed-by: Renovate Bot <renovate-bot@gitea.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yacaovsnc yacaovsnc yacaovsnc approved these changes

@luketomlinson luketomlinson luketomlinson approved these changes

+1 more reviewer

@johngitbuild-art johngitbuild-art johngitbuild-art approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@joshmgross @reemasardana @yacaovsnc @luketomlinson @johngitbuild-art