Conversation
jepler
changed the title
|
I think all the new directives & instructions are handled. However, I'd like to wait to merge this until the new StateMachine constructor parameters are supported in the core, just in case some changes end up needed there. |
.. and correct .mov_status irq prev and range handling
* As an extension, ".fifo auto" may be specified to request CircuitPython's auto fifo join behavior * bounds check on `.set` directive improved * redundant kwargs (e.g., out_count vs out_pin_count) fixed
|
👋 Thanks for this pull request! Unfortunately, it looks like the automated continuous integration (CI) test(s) failed. These can be tricky to fix so we've written a guide on how to fix them locally. It has pages about running pre-commit locally and another about building the docs locally with sphinx. Thanks for contributing to CircuitPython! If you have more questions, feel free to join the Adafruit Discord and post in #circuitpython-dev. |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Thanks for taking this on! There are a lot of little details and I think I found a couple spots that don't match the datasheet.
this feature is in all PIO versions
|
oops, re-requested review but I missed a couple of points. will continue fixing. |
the failing tests will be addressed next. They fall into two simple classes, both pertaining to the new piov1 instructions.
|
OK now it's actually read for re-review (though I'm not likely to act on anything today or probably before monday so no rush) |
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
One structural request. Good otherwise. Thanks for generating tests for everything!
.. not part of the testsuite proper.
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL37x to 1.2.0 from 1.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_ADXL37x#7 from RoaCode/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.5.0 from 1.4.19: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#57 from matthewbadeau/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.1.0 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#71 from adafruit/doc > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#68 from adafruit/rp2350 > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#70 from adafruit/fix-rotaryencoder-example Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.10.0 from 1.9.18: > Merge pull request adafruit/Adafruit_CircuitPython_Register#57 from mikeysklar/ds3231-alarm2-minute-status Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
2 participants
New StateMachine constructor parameters will need to be added in the core. However, when these features are not used, the new constructor parameters will not be in
pio_kwargsso backward compatibility is preserved.Directives:
Instructions:
Closes #67