Merged
Conversation
ds3231: minute support status frequency re-order
more obvious to add an additional else than to get cray cray and make the logic truly unreadable.
Contributor
Author
|
@FoamyGuy or @caternuson - would you like to see further testing? @b-blake and myself have confirmed the PR works on the DS3231. I can test on other RTCs. Since @b-blake provided the code and requested this be added over a year ago maybe a release can be cut soon? |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Sep 24, 2024
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADXL37x to 1.2.0 from 1.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_ADXL37x#7 from RoaCode/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MIDI to 1.5.0 from 1.4.19: > Merge pull request adafruit/Adafruit_CircuitPython_MIDI#57 from matthewbadeau/main Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.1.0 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#71 from adafruit/doc > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#68 from adafruit/rp2350 > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#70 from adafruit/fix-rotaryencoder-example Updating https://github.com/adafruit/Adafruit_CircuitPython_Register to 1.10.0 from 1.9.18: > Merge pull request adafruit/Adafruit_CircuitPython_Register#57 from mikeysklar/ds3231-alarm2-minute-status Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ds3231:
minute support
status
frequency re-order
@b-blake provided code from issue #50
test script used: