fix: load sandbox brands from SDK, simplify training agent rights#2165
Merged
Conversation
…ights (#508) Replace hardcoded advertiser brands with getSandboxBrands() from the SDK. Simplify rights handlers to talent-only (remove session state, brand-level rights offerings). Restore input guards on acquire_rights and get_rights. Fix creative_approval to validate rights_id against known offerings. Bump @adcp/client to 4.30.1. Remove dry_run from ComplyOptions and StoryboardRunOptions call sites (removed upstream in SDK). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Keep our getSandboxBrands() loading, stateless rights handlers, and dry_run removal. Take main's package.json versions with @adcp/client bump. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ADVERTISER_BRANDSwithgetSandboxBrands()from@adcp/client— new sandbox brands added to the SDK appear in the training agent automaticallycampaign.descriptionnull guard inacquire_rightsuses.length > 0guard inget_rights(empty array was filtering out all results)rights_idvalidation tocreative_approval(must match a known offering)dry_runtype errors from SDK bump (removed fromComplyOptions/StoryboardRunOptions)creative_templatestoryboard test for new 4-phase structureTestKit.brandandTestKit.assetsoptionalBump
@adcp/clientfrom 4.26.2 to 4.30.1.Partially addresses adcontextprotocol/adcp-client#508 (items 2-4).
Test plan
acme_outdoor,nova_motors,bistro_oranje,osei_natural,summit_foods)creative_approvalrejects unknownrights_id🤖 Generated with Claude Code