Skip to content

Fix missing newlines between context sections in Addie Slack messages#508

Merged
bokelley merged 1 commit into
mainfrom
bokelley/addie-newline-fix
Jan 3, 2026
Merged

Fix missing newlines between context sections in Addie Slack messages#508
bokelley merged 1 commit into
mainfrom
bokelley/addie-newline-fix

Conversation

@bokelley

@bokelley bokelley commented Jan 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Fixed missing newlines between member context and channel context sections in Addie Slack message formatting
  • When both contexts were present, they were concatenated without proper markdown paragraph spacing, causing sections to run together
  • Used array filter/join pattern for cleaner section joining with \n\n

Test plan

  • Verify Slack messages with both member and channel context display proper spacing
  • Verify messages with only member context still work correctly
  • Verify messages with only channel context still work correctly
  • Unit tests pass

🤖 Generated with Claude Code

When both member context and channel context were present in Slack
messages, they were concatenated directly without proper markdown
paragraph spacing. This caused sections to run together visually.

Changes:
- Remove leading \n from channel context header (was a workaround)
- Use array filter/join pattern to properly space sections with \n\n
- Add extra newline before --- separator for consistent formatting

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@bokelley bokelley merged commit 3def784 into main Jan 3, 2026
6 checks passed
bokelley added a commit that referenced this pull request Apr 15, 2026
…ights (#508)

Replace hardcoded advertiser brands with getSandboxBrands() from the SDK.
Simplify rights handlers to talent-only (remove session state, brand-level
rights offerings). Restore input guards on acquire_rights and get_rights.
Fix creative_approval to validate rights_id against known offerings.

Bump @adcp/client to 4.30.1. Remove dry_run from ComplyOptions and
StoryboardRunOptions call sites (removed upstream in SDK).

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
bokelley added a commit that referenced this pull request Apr 15, 2026
…ights (#508) (#2165)

Replace hardcoded advertiser brands with getSandboxBrands() from the SDK.
Simplify rights handlers to talent-only (remove session state, brand-level
rights offerings). Restore input guards on acquire_rights and get_rights.
Fix creative_approval to validate rights_id against known offerings.

Bump @adcp/client to 4.30.1. Remove dry_run from ComplyOptions and
StoryboardRunOptions call sites (removed upstream in SDK).

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant