chore: root tsconfig strict: true#2896
Merged
Merged
Conversation
Bumps @adcp/client 5.11.0 → 5.12.0 and flips the root tsconfig.json from strict: false to strict: true. The CI typecheck runs under server/tsconfig.json, which has always been strict; this aligns the root config (used by IDEs and local `npx tsc --noEmit`) with CI behavior. Zero code changes — codebase already passes under --strict. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
PR #2891 already bumped @adcp/client to 5.12.0 and adjusted storyboard floors. After merging main, this PR's only remaining change is flipping root tsconfig to strict: true. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
bokelley
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Flip root
tsconfig.jsonfromstrict: false→strict: trueto matchserver/tsconfig.json(which CI uses vianpm run typecheck).The root config is used by IDEs and local
npx tsc --noEmit. Leaving it loose meant local/IDE type-checking diverged from CI — TS 5.9 won't narrow!result.okon boolean-literal discriminated unions withoutstrictNullChecks, producing false local errors while CI was fine.Zero code changes required — the codebase already passes under
--strict.Scope reduction: initially bundled an
@adcp/client5.12.0 bump, but #2891 landed that first on main. After merging main, only the tsconfig flip remains.Test plan
npm run typecheckcleannpm run test:unit(631 passed)npm run test:server-unit(1904+ passed)npx tsc --noEmitat repo root now matches CI🤖 Generated with Claude Code