chore(deps): bump @adcp/client to 5.12.0 (closes most framework zod-parity gap)#2891
Merged
Conversation
Picks up the SDK's spec-shaped request-builders for log_event, create_media_buy, list_creative_formats, si_*, sync_governance (adcp-client#794, #789, #802) and the VALIDATION_ERROR retry-storm guard (adcp-client#758). Closes most of the framework-mode zod-parity gap. Both legacy and framework regress on the bump because adcp-client#794 makes the runner emit every authored package on create_media_buy, exposing per-package products our catalog does not seed. Adjusts CI baselines to the new floor; fixture-seeding follow-up tracked separately. Framework-only delta vs. legacy is now 5 storyboards / 7 step failures, listed in the changeset.
The initial bump used a local tarball during validation; the committed lockfile carried that file:// path, breaking CI which can't resolve it. Reinstall from the registry so the lockfile points at npm.
) Every use case run-one-storyboard.ts supported is now covered by the published adcp CLI (shipped in @adcp/client 5.12): - Single-storyboard diagnostic run: adcp storyboard run <url> <id> - Single-step debug: adcp storyboard step <url> <id> <step> - JSON + JUnit output native run-storyboards.ts stays — the dual-mode CI matrix and per-storyboard test_kit / /mcp-strict routing it encodes doesn't fit the helper's single-agent-one-config shape. Retirement tracked as an upstream RFC for per-storyboard config on runAgainstLocalAgent.
…rlay My original baselines (42/37) were taken from a local run where I'd overlaid static/compliance/source/ onto the SDK cache. Without that overlay, CI sees 38/32 clean on the bump — matching the fixture-seeding regression documented in the PR. Lower the floor here; the follow-up fixtures PR (adcp#2894) lifts it back up.
bokelley
added a commit
that referenced
this pull request
Apr 22, 2026
PR #2891 already bumped @adcp/client to 5.12.0 and adjusted storyboard floors. After merging main, this PR's only remaining change is flipping root tsconfig to strict: true. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
6 tasks
bokelley
added a commit
that referenced
this pull request
Apr 22, 2026
* chore(deps): bump @adcp/client to 5.12.0, tsconfig strict: true Bumps @adcp/client 5.11.0 → 5.12.0 and flips the root tsconfig.json from strict: false to strict: true. The CI typecheck runs under server/tsconfig.json, which has always been strict; this aligns the root config (used by IDEs and local `npx tsc --noEmit`) with CI behavior. Zero code changes — codebase already passes under --strict. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: rename changeset after main merge (5.12 bump already landed) PR #2891 already bumped @adcp/client to 5.12.0 and adjusted storyboard floors. After merging main, this PR's only remaining change is flipping root tsconfig to strict: true. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@adcp/clientfrom^5.11.0→^5.12.0. Closes most of the framework-mode storyboard zod-parity gap by picking up the SDK's spec-shaped request-builders.What lands with this bump
log_event+create_media_buybuilders honorstep.sample_requestand emit spec shapes (adcp-client#794, closes adcp#2872 root cause)list_creative_formatsbuilder honorssample_request(adcp-client#789, mine — closes adcp-client#780)si_*+sync_governancebuilders honorsample_requestand conform to zod (adcp-client#802)VALIDATION_ERRORretry-storm guard (adcp-client#758) — caches the validation envelope for 10s so a drifted handler can't loop on retrywrapEnvelopepublic export,runAgainstLocalAgenttesting helper, seed merge helpers,get_productstest-controller bridgeCI baseline adjustment
Both legacy and framework regress on the bump because adcp-client#794 makes the runner emit every authored package on
create_media_buy, exposing that several storyboards reference per-package products our catalog does not seed:outdoor_video_q2,late_fringe_15s_mf,outdoor_ctv_q2_guaranteed,lifestyle_display_q2Cascades into downstream
get_deliveryfailures on the same buys.The product-fixture follow-up is wiring the affected storyboards to
controller_seeding: true+fixtures:blocks (the SDK side already shipped in adcp-client#790).Framework-only delta (residual #30 work)
After the bump, the framework-mode-only failures vs. legacy are 5 storyboards / 7 step failures:
acquire_rights_denied(brand_rights/governance_denied) —GOVERNANCE_DENIEDerror code stripped from responsecalibrate_must_violation+calibrate_after_policy_change(content_standards) — handler returnspasswhen storyboard expectsfaillog_event(sales_social) +log_events(sales_catalog_driven) —EVENT_SOURCE_NOT_FOUND(session-state lookup diverges between dispatch paths)provide_feedback(sales_catalog_driven) —MEDIA_BUY_NOT_FOUND(same session-state pattern)report_usage(creative_ad_server) —acceptedfield type mismatch in responseTracked as a separate task. The shape of the work is now scoped — these are response-shaping or handler-state issues, not zod input gaps.
Test plan
tsc --project server/tsconfig.json --noEmitclean🤖 Generated with Claude Code