fix(compliance): default governance_agent_url to seller-local stub (#5665) [Option B — alternative]#5677
Closed
danyliukmykola wants to merge 1 commit into
Conversation
…dcontextprotocol#5665) Option B (alternative) for adcontextprotocol#5665: point the default governance_agent_url at a seller-served stub instead of the external training agent, removing the counterparty-supplied-URL egress/SSRF surface. Keeps the scenario mandatory; depends on runner support for a controller-self-URL placeholder. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
IPR Policy Agreement Required@danyliukmykola — thanks for the contribution. Before this PR can be merged, the AgenticAdvertising.Org IPR Policy requires your agreement. To agree, post a new comment on this PR with the exact phrase: Your signature is recorded once and covers all contributions to AAO repositories. See |
Contributor
|
Closing in favor of Option A (#5676), now merged. Recap of why A over B, after independent verification of the runner:
The SSRF concern B was reaching for is real and tracked separately as a docs follow-up (governance_agents[].url missing from the security.mdx SSRF enumeration). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to the Option A PR for #5665, per the triage's Option B. Opened for completeness so the A-vs-B call can be made against concrete diffs.
Defaults
governance_agent_urlto a seller-served stub (the seller's owncomply_test_controller), removing the counterparty-supplied-URL egress/SSRF surface.Two caveats vs Option A:
not_applicableopt-out the issue title asks for. Sellers still must implement outbound governance consultation (now against a local stub instead of an external agent).{{runner.controller_url}}doesn't exist yet (only{{runner.webhook_url:…}}and{{prior_step.…}}are runner-managed today), so this spans adcp-client too, not just scenario YAML.We'd lean Option A — self-contained, and it actually creates the opt-out.