Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .changeset/5665-governance-agent-url-seller-stub.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
---

Empty changeset: Default `governance_agent_url` in the `governance_denied` / `governance_denied_recovery` storyboards to a seller-local stub served by the seller's `comply_test_controller`, removing the counterparty-supplied-URL egress/SSRF surface. Alternative to #5665 Option A; depends on runner support for a controller-self-URL placeholder. Addresses #5665 (Option B).
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,15 @@ narrative: |
(e.g., via `--context` on `adcp storyboard run` once the CLI supports it).

context:
governance_agent_url: "https://test-agent.adcontextprotocol.org"
# Option B (#5665): default the governance agent to a seller-local stub served
# by the seller's own comply_test_controller, instead of the external training
# agent. This removes the counterparty-supplied-URL egress/SSRF surface (the
# seller calls its own controller) and lets sellers without an external
# governance agent still exercise the denial path. NOTE: depends on the runner
# exposing a controller-self-URL placeholder (cf. {{runner.webhook_url:...}});
# {{runner.controller_url}} does not exist yet — adcp-client support required.
# An explicit --context governance_agent_url still overrides this default.
governance_agent_url: "{{runner.controller_url}}/stub-governance-agent"

agent:
interaction_model: media_buy_seller
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,15 @@ narrative: |
(e.g., via `--context` on `adcp storyboard run` once the CLI supports it).

context:
governance_agent_url: "https://test-agent.adcontextprotocol.org"
# Option B (#5665): default the governance agent to a seller-local stub served
# by the seller's own comply_test_controller, instead of the external training
# agent. This removes the counterparty-supplied-URL egress/SSRF surface (the
# seller calls its own controller) and lets sellers without an external
# governance agent still exercise the denial path. NOTE: depends on the runner
# exposing a controller-self-URL placeholder (cf. {{runner.webhook_url:...}});
# {{runner.controller_url}} does not exist yet — adcp-client support required.
# An explicit --context governance_agent_url still overrides this default.
governance_agent_url: "{{runner.controller_url}}/stub-governance-agent"

agent:
interaction_model: media_buy_seller
Expand Down
Loading