Fix for issue #657#658
Conversation
|
Reviewing... |
|
What's the order on Windows? I don't have a Windows machine handy. @adrocknaphobia ? |
There was a problem hiding this comment.
Thanks for the fix Ryan. It looks like Windows lists Ctrl first while on Mac Command is last.Can you update your code with the following to handle both platforms?
if (hasCtrl) {
// Windows display Ctrl first, Mac displays Command symbol last
if (brackets.platform === "win") {
keyDescriptor.unshift("Ctrl");
} else {
keyDescriptor.push("Ctrl");
}
}
|
done reviewing |
|
Tweaked as per @tvoliter's code. Haven't tested on windows yet though. |
|
Ty integrated this change in #667. @ryanstewart Please confirm and feel free to close out this pull request without merging. |
|
Ryan, I copied your code into another pull request I had since I was merging some of your code anyway. |
|
Sweet, thanks! |
Fixed the issue (at least on Mac) about key bindings being out of order compared to other Mac apps.