✅ Sync 066be76ee5d: [release/10.0] Source code updates from dotnet/dotnet (#124136)#64
Closed
github-actions[bot] wants to merge 2 commits into
Closed
✅ Sync 066be76ee5d: [release/10.0] Source code updates from dotnet/dotnet (#124136)#64github-actions[bot] wants to merge 2 commits into
github-actions[bot] wants to merge 2 commits into
Conversation
> [!NOTE] > This is a codeflow update. It may contain both source code changes from > [the VMR](https://github.com/dotnet/dotnet) > as well as dependency updates. Learn more [here](https://github.com/dotnet/dotnet/tree/main/docs/Codeflow-PRs.md). This pull request brings the following source code changes [marker]: <> (Begin:74dc5d43-0b13-491a-b063-0f03b26d7664) ## From https://github.com/dotnet/dotnet - **Subscription**: [74dc5d4-0b13-491a-b063-0f03b26d7664](https://maestro.dot.net/subscriptions?search=74dc5d43-0b13-491a-b063-0f03b26d7664) - **Build**: [20260210.24](https://dev.azure.com/dnceng/internal/_build/results?buildId=2900845) ([301313](https://maestro.dot.net/channel/5173/github:dotnet:dotnet/build/301313)) - **Date Produced**: February 11, 2026 9:20:37 AM UTC - **Commit**: [9d0c3bebf9d368ad51c0b9a7b954219d192cd9d6](dotnet/dotnet@9d0c3be) - **Commit Diff**: [52be957...9d0c3be](dotnet/dotnet@52be957...9d0c3be) - **Branch**: [release/10.0.1xx](https://github.com/dotnet/dotnet/tree/release/10.0.1xx) **Updated Dependencies** - From [5.0.0-2.26102.102 to 5.0.0-2.26110.124][6] - Microsoft.CodeAnalysis - Microsoft.CodeAnalysis.Analyzers - Microsoft.CodeAnalysis.CSharp - Microsoft.Net.Compilers.Toolset - From [10.0.104 to 10.0.104][6] - Microsoft.CodeAnalysis.NetAnalyzers - Microsoft.DotNet.ApiCompat.Task - From [10.0.0-beta.26102.102 to 10.0.0-beta.26110.124][6] - Microsoft.DotNet.Arcade.Sdk - Microsoft.DotNet.Build.Tasks.Archives - Microsoft.DotNet.Build.Tasks.Feed - Microsoft.DotNet.Build.Tasks.Installers - Microsoft.DotNet.Build.Tasks.Packaging - Microsoft.DotNet.Build.Tasks.TargetFramework - Microsoft.DotNet.Build.Tasks.Templating - Microsoft.DotNet.Build.Tasks.Workloads - Microsoft.DotNet.CodeAnalysis - Microsoft.DotNet.GenAPI - Microsoft.DotNet.GenFacades - Microsoft.DotNet.Helix.Sdk - Microsoft.DotNet.PackageTesting - Microsoft.DotNet.RemoteExecutor - Microsoft.DotNet.SharedFramework.Sdk - Microsoft.DotNet.XliffTasks - Microsoft.DotNet.XUnitExtensions - From [0.11.5-alpha.26102.102 to 0.11.5-alpha.26110.124][6] - Microsoft.DotNet.Cecil - From [2.9.3-beta.26102.102 to 2.9.3-beta.26110.124][6] - Microsoft.DotNet.XUnitAssert - Microsoft.DotNet.XUnitConsoleRunner - From [10.0.4 to 10.0.4][6] - Microsoft.NET.Sdk.IL - Microsoft.NETCore.App.Ref - Microsoft.NETCore.ILAsm - runtime.native.System.IO.Ports - System.Reflection.Metadata - System.Reflection.MetadataLoadContext - System.Text.Json - From [10.0.104-servicing.26102.102 to 10.0.104-servicing.26110.124][6] - Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport - From [7.0.2-rc.10302 to 7.0.2-rc.11124][6] - NuGet.Frameworks - NuGet.Packaging - NuGet.ProjectModel - NuGet.Versioning - From [2.0.4 to 2.0.4][6] - System.CommandLine - From [10.0.0-alpha.1.26076.1 to 10.0.0-alpha.1.26104.2](dotnet/dotnet@da47e69...b5b1233) - runtime.linux-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-musl-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-musl-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.linux-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.osx-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.osx-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.win-arm64.Microsoft.NETCore.Runtime.Wasm.Node.Transport - runtime.win-x64.Microsoft.NETCore.Runtime.Wasm.Node.Transport [marker]: <> (End:74dc5d43-0b13-491a-b063-0f03b26d7664) [1]: dotnet/dotnet@52be957...3f106e5 [2]: dotnet/dotnet@52be957...c33eae4 [3]: dotnet/dotnet@52be957...7768201 [4]: dotnet/dotnet@52be957...3628157 [5]: dotnet/dotnet@52be957...a95a98f [6]: dotnet/dotnet@52be957...9d0c3be [marker]: <> (Start:Footer:CodeFlow PR) ## Associated changes in source repos - dotnet/arcade@af17297...58d7536 - dotnet/aspnetcore@693d402...0c6d74d - dotnet/efcore@52a750f...dffd57b - dotnet/runtime@59908f6...9ffba73 - dotnet/sdk@bc6b89b...6b09479 - dotnet/source-build-assets@a70be36...89fffcb - dotnet/sourcelink@bd09f31...2752a5e - dotnet/templating@21a0fc0...8f46f06 - dotnet/windowsdesktop@0ea907c...fbf65c7 - dotnet/winforms@4e97eb7...27d66ad - dotnet/wpf@23f6b49...36f3469 <details> <summary>Diff the source with this PR branch</summary> ```bash darc vmr diff --name-only https://github.com/dotnet/dotnet:9d0c3bebf9d368ad51c0b9a7b954219d192cd9d6..https://github.com/dotnet/runtime:darc-release/10.0-796345f8-10d3-4632-a948-88c3a0c89e57 ``` </details> [marker]: <> (End:Footer:CodeFlow PR) --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…ease-10.0-066be76ee5d
agocke
added a commit
that referenced
this pull request
Mar 14, 2026
The detection script previously treated eng/Version.Details.props and eng/Versions.props as 'version bump, informational' and never flagged them as build-relevant. This is wrong because Bazel's paket/paket.main.bzl and MODULE.bazel embed NuGet package versions that must stay in sync with the MSBuild version props. Changes: - Remove blanket is_version_only exemption for version props files - Cross-reference changed package names against paket/paket.main.bzl to detect when version bumps affect packages used by the Bazel build - Increase diff snippet from head -10 to head -20 to reduce misleading truncation in PR body reports Tested against PR #64 (sync/release-10.0-066be76ee5d): now correctly classifies as build-changes and identifies 9 affected Bazel NuGet deps including Microsoft.DotNet.Arcade.Sdk, GenFacades, and XUnitConsoleRunner. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agocke
added a commit
that referenced
this pull request
Mar 14, 2026
…t deps (#65) ## Problem The sync detection script treats `eng/Version.Details.props` as "version bump, informational" and never flags it as `build-changes`. This is wrong — NuGet package versions are embedded in `MODULE.bazel` and `paket/paket.main.bzl`, so version bumps can cause stale Bazel refs. PR #64 demonstrates this: classified as ✅ clean despite bumping versions for packages like `Microsoft.DotNet.Arcade.Sdk` that are pinned in the Bazel build. ## Fix - Remove the blanket `is_version_only` exemption for version props files - Cross-reference changed package names (extracted from MSBuild property names) against packages declared in `paket/paket.main.bzl` - If any changed package is used by Bazel, flag as `build-changes`; otherwise mark as _(version bump, no Bazel NuGet deps affected)_ - Increase diff snippet limit from `head -10` to `head -20` to reduce misleading truncation ## Testing Ran against the PR #64 diff (`sync/release-10.0-066be76ee5d`): **Before:** ✅ clean (exit 0) **After:**⚠️ build-changes (exit 1), identifying 9 affected packages: `Microsoft.DotNet.Arcade.Sdk`, `Microsoft.DotNet.GenFacades`, `Microsoft.DotNet.XUnitConsoleRunner`, `Microsoft.DotNet.Cecil`, `Microsoft.DotNet.RemoteExecutor`, `Microsoft.DotNet.XUnitAssert`, `Microsoft.DotNet.XUnitExtensions`, `Microsoft.CodeAnalysis.Analyzers`, `Microsoft.CodeAnalysis.CSharp` Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream commit:
066be76ee5d— [release/10.0] Source code updates from dotnet/dotnet (dotnet#124136)\nRemaining after this: 17 commit(s)\n\n---\n\n# Sync Report:release/10.0→bazelUpstream commits: 1 | Files changed: 5
Classification: ✅ clean — No Bazel-relevant build changes detected
🔧 Modified Build Properties (.props/.targets)
These may affect compilation defines, references, or file includes:
eng/Version.Details.props(version bump, informational)- <MicrosoftCodeAnalysisPackageVersion>5.0.0-2.26102.102</MicrosoftCodeAnalysisPackageVersion>