Fix sync detection: flag version props changes that affect Bazel NuGet deps#65
Merged
Merged
Conversation
The detection script previously treated eng/Version.Details.props and eng/Versions.props as 'version bump, informational' and never flagged them as build-relevant. This is wrong because Bazel's paket/paket.main.bzl and MODULE.bazel embed NuGet package versions that must stay in sync with the MSBuild version props. Changes: - Remove blanket is_version_only exemption for version props files - Cross-reference changed package names against paket/paket.main.bzl to detect when version bumps affect packages used by the Bazel build - Increase diff snippet from head -10 to head -20 to reduce misleading truncation in PR body reports Tested against PR #64 (sync/release-10.0-066be76ee5d): now correctly classifies as build-changes and identifies 9 affected Bazel NuGet deps including Microsoft.DotNet.Arcade.Sdk, GenFacades, and XUnitConsoleRunner. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
agocke
pushed a commit
that referenced
this pull request
Apr 23, 2026
* Keep instance fields on types with explicit or sequential layout * Check for static flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The sync detection script treats
eng/Version.Details.propsas "version bump, informational" and never flags it asbuild-changes. This is wrong — NuGet package versions are embedded inMODULE.bazelandpaket/paket.main.bzl, so version bumps can cause stale Bazel refs.PR #64 demonstrates this: classified as ✅ clean despite bumping versions for packages like
Microsoft.DotNet.Arcade.Sdkthat are pinned in the Bazel build.Fix
is_version_onlyexemption for version props filespaket/paket.main.bzlbuild-changes; otherwise mark as (version bump, no Bazel NuGet deps affected)head -10tohead -20to reduce misleading truncationTesting
Ran against the PR #64 diff (
sync/release-10.0-066be76ee5d):Before: ✅ clean (exit 0)⚠️ build-changes (exit 1), identifying 9 affected packages:
After:
Microsoft.DotNet.Arcade.Sdk,Microsoft.DotNet.GenFacades,Microsoft.DotNet.XUnitConsoleRunner,Microsoft.DotNet.Cecil,Microsoft.DotNet.RemoteExecutor,Microsoft.DotNet.XUnitAssert,Microsoft.DotNet.XUnitExtensions,Microsoft.CodeAnalysis.Analyzers,Microsoft.CodeAnalysis.CSharp