Conversation
fix(core): resolve issue 137 and stabilize unity e2e flows
Cargo dependencies were missing from dependabot.yml, causing PRs to target main instead of develop. This adds the cargo ecosystem with target-branch: develop to match npm and github-actions config. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Bumps [pnpm/action-setup](https://github.com/pnpm/action-setup) from 4 to 5. - [Release notes](https://github.com/pnpm/action-setup/releases) - [Commits](pnpm/action-setup@v4...v5) --- updated-dependencies: - dependency-name: pnpm/action-setup dependency-version: '5' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…dates (#141) Bumps the npm_and_yarn group with 5 updates in the / directory: | Package | From | To | | --- | --- | --- | | [@commitlint/cli](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/cli) | `20.4.3` | `20.5.0` | | [@commitlint/config-conventional](https://github.com/conventional-changelog/commitlint/tree/HEAD/@commitlint/config-conventional) | `20.4.3` | `20.5.0` | | [@google/gemini-cli](https://github.com/google-gemini/gemini-cli) | `0.32.1` | `0.34.0` | | [@openai/codex](https://github.com/openai/codex/tree/HEAD/codex-cli) | `0.113.0` | `0.116.0` | | [eslint](https://github.com/eslint/eslint) | `10.0.3` | `10.1.0` | Updates `@commitlint/cli` from 20.4.3 to 20.5.0 - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/cli/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.5.0/@commitlint/cli) Updates `@commitlint/config-conventional` from 20.4.3 to 20.5.0 - [Release notes](https://github.com/conventional-changelog/commitlint/releases) - [Changelog](https://github.com/conventional-changelog/commitlint/blob/master/@commitlint/config-conventional/CHANGELOG.md) - [Commits](https://github.com/conventional-changelog/commitlint/commits/v20.5.0/@commitlint/config-conventional) Updates `@google/gemini-cli` from 0.32.1 to 0.34.0 - [Release notes](https://github.com/google-gemini/gemini-cli/releases) - [Changelog](https://github.com/google-gemini/gemini-cli/blob/main/docs/releases.md) - [Commits](google-gemini/gemini-cli@v0.32.1...v0.34.0) Updates `@openai/codex` from 0.113.0 to 0.116.0 - [Release notes](https://github.com/openai/codex/releases) - [Commits](https://github.com/openai/codex/commits/rust-v0.116.0/codex-cli) Updates `eslint` from 10.0.3 to 10.1.0 - [Release notes](https://github.com/eslint/eslint/releases) - [Commits](eslint/eslint@v10.0.3...v10.1.0) --- updated-dependencies: - dependency-name: "@commitlint/cli" dependency-version: 20.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn - dependency-name: "@commitlint/config-conventional" dependency-version: 20.5.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn - dependency-name: "@google/gemini-cli" dependency-version: 0.34.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn - dependency-name: "@openai/codex" dependency-version: 0.116.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn - dependency-name: eslint dependency-version: 10.1.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5 to 6. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v5...v6) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-version: '6' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#139) Bumps the cargo group with 1 update in the / directory: [rustls-webpki](https://github.com/rustls/webpki). Updates `rustls-webpki` from 0.103.9 to 0.103.10 - [Release notes](https://github.com/rustls/webpki/releases) - [Commits](rustls/webpki@v/0.103.9...v/0.103.10) --- updated-dependencies: - dependency-name: rustls-webpki dependency-version: 0.103.10 dependency-type: indirect dependency-group: cargo ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…#134) Bumps the npm_and_yarn group with 1 update in the / directory: [undici](https://github.com/nodejs/undici). Updates `undici` from 7.22.0 to 7.24.1 - [Release notes](https://github.com/nodejs/undici/releases) - [Commits](nodejs/undici@v7.22.0...v7.24.1) --- updated-dependencies: - dependency-name: undici dependency-version: 7.24.1 dependency-type: indirect dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps the npm_and_yarn group with 2 updates: [@google/gemini-cli](https://github.com/google-gemini/gemini-cli) and [@openai/codex](https://github.com/openai/codex/tree/HEAD/codex-cli). Updates `@google/gemini-cli` from 0.34.0 to 0.36.0 - [Release notes](https://github.com/google-gemini/gemini-cli/releases) - [Changelog](https://github.com/google-gemini/gemini-cli/blob/main/docs/releases.md) - [Commits](google-gemini/gemini-cli@v0.34.0...v0.36.0) Updates `@openai/codex` from 0.116.0 to 0.118.0 - [Release notes](https://github.com/openai/codex/releases) - [Commits](https://github.com/openai/codex/commits/rust-v0.118.0/codex-cli) --- updated-dependencies: - dependency-name: "@google/gemini-cli" dependency-version: 0.36.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn - dependency-name: "@openai/codex" dependency-version: 0.118.0 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com>
…npm_and_yarn-acda4d4975 chore(deps): bump the npm_and_yarn group with 2 updates
…l plugin distribution (#160) Establishes a machine-verifiable Claude Code / Codex skill contract and migrates all 13 unity-* skills to it in a single PR. Skills are now shared between the Claude Code plugin (`.claude-plugin/`) and the newly introduced Codex plugin (`.codex-plugin/` + `.agents/skills/` + `.agents/plugins/`) via a single source of truth under `.claude-plugin/plugins/unity-cli/skills/`. Why - description-based triggering was informal and inconsistent across skills. - Codex CLI published a formal plugin spec (`.codex-plugin/plugin.json`, `.agents/skills/`, `.agents/plugins/marketplace.json`) in late 2025 but the repo still used the pre-spec `.codex/skills/` layout. - `gh-skills-sync` is a development helper for this repository itself and should not ship inside the distributed plugin. - No dedicated gwt-spec Issue tracked skill concerns; closest was #145 (CLI core) which only mentioned skill routing in passing. What - New Rust module `src/skills/` implementing loader, domain model, report, runner, and rules R01..R22 (Skill Contract v1). Exposed via `unity-cli skills lint [--root --format --severity --fix]`. - 22 unit tests under `src/skills/tests.rs` (one RED example per rule + a good_skill pass-all). - Migrated 13 unity-* skills: frontmatter (metadata.triggers/siblings), description rewritten to Verb+object imperative with sibling mention, body rewritten to the 5 required H2 sections, `references/runtime-checklist.md` copied into every skill, `unity-csharp-edit` receives `Edit, Write`, `unity-cli-usage` becomes `user-invocable: false`. - Created `.codex-plugin/plugin.json`, `.agents/skills/` symlinks, `.agents/plugins/marketplace.json`. Deleted legacy `.codex/skills/`. Codex-only helpers (`gh-fix-ci`, `gh-fix-issue`, `gh-pr`, `gh-pr-check`) moved from `.codex/skills/` to `.agents/skills/`. - Bumped `.claude-plugin/plugins/unity-cli/plugin.json` to 0.2.0 with explicit `skills: "./skills/"`. Bumped marketplace to 0.2.0. - Moved `gh-skills-sync` to `dev-skills/gh-skills-sync/` (out of plugin). - `CLAUDE.md`, `docs/skills.md` (new), `docs/development.md` updated to reflect the contract. `CONTRIBUTING.md` added inside the plugin with the new-skill checklist and PR template fragment. - Replaced `scripts/skill-eval/static-skill-contract-check.sh` with `cargo run -- skills lint --severity error` in `.github/workflows/lint.yml` and `.github/workflows/skill-routing-eval.yml`. Legacy script deleted. Verification - `cargo fmt --all -- --check` - `cargo clippy --all-targets -- -D warnings` - `cargo test --all-targets` — 246 passed (incl. 22 new skill linter tests) - `cargo run -- skills lint --severity error` — 13 skills, 0 violations - `.claude/skills/` and `.agents/skills/` symlinks resolve to canonical source - `.codex/` removed, `gh-skills-sync` in `dev-skills/`, plugin manifests at 0.2.0 Refs: #160, #145 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
feat(skills): add unity development loop skill
…t-v1-160 # Conflicts: # .agents/skills/unity-development-loop
feat(skills): Skill Contract v1, unity-cli skills lint, dual plugin distribution (#160)
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (96)
概要WalkthroughSkill Contract v1 による統一的なスキル定義・検証システムの導入、Rust 実装の Changes
Sequence Diagram(s)sequenceDiagram
participant User as ユーザー
participant CLI as CLI (main)
participant Loader as Loader
participant RuleEngine as Rule Engine
participant Report as Report
User->>CLI: cargo run -- skills lint --severity error
CLI->>CLI: CLI パース
CLI->>Loader: load_skills(root)
Loader->>Loader: SKILL.md 走査
Loader-->>CLI: Vec<Skill>
CLI->>RuleEngine: run_all(skill, context)
loop スキルごと
RuleEngine->>RuleEngine: R01–R22 規則実行
RuleEngine-->>CLI: Vec<Violation>
end
CLI->>Report: render(outcome, Text, severity)
Report-->>CLI: formatted_output
CLI-->>User: stdout + exit code
Estimated code review effort🎯 4 (Complex) | ⏱️ ~60 minutes Possibly related issues
Possibly related PRs
Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unity-cli skills lintコマンドの追加Changes
unity-cli skills lint) を実装。Claude Code / Codex 向けデュアルプラグイン配布に対応 (gwt-spec: Skill契約・Lint・デュアルプラグイン配布 #160)Version
v0.10.0
Closing Issues
Closes #145
Closes #158
🤖 Generated with Claude Code
Summary by CodeRabbit
リリースノート
新機能
ドキュメント
Chores