docs(lessons): gwt-spec の集約 close 例外条項を追加#205
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
akiojin
force-pushed
the
work/20260512-0246
branch
from
75ac1e2 to
3cac2eb
Compare
cargo test / dotnet test を pre-push から削除し、format check だけ 残す。重いテストは CI に任せて push loop を高速化し、既存の並列実行 race condition (flaky integration tests) で push がブロックされる 事象を避ける。 Refs #204
Rust の std::env::set_var は process-global で thread-unsafe、 複数 test が UNITY_CLI_REGISTRY_PATH / HOME を mutate すると library 内部の getenv 読み出しと衝突して flaky に失敗していた (PR #205 で `write_pid_and_cleanup_use_temp_home` / `execution_ context_uses_defaults` / `run_with_cli_set_active_text_output_ when_reachable` が intermittent に fail)。 CI workflow と CLAUDE.md の品質ゲートを cargo llvm-cov 側に既に 存在した --test-threads=1 と同じ運用に揃え、test 実行を serialize する。tasks/lessons.md に再発防止 rule を追加。 Refs #204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
tasks/lessons.md: 2026-05-12 lesson「正式な gwt-spec を close しない」の Rule / Checkpoint に集約 close 例外条項を追加 (Rule: canonical 後継 SPEC が存在する場合に限り旧 SPEC を close 可、Checkpoint: 集約 close なら最終コメントに集約先 SPEC 番号を明記)Testing
git diff origin/develop..HEAD -- tasks/lessons.md— Rule 行と Checkpoint 行に例外条項が追記されているgh issue list --label gwt-spec --state open— gwt-spec: unity-csharp-reference (UnityCsReference 参照キャッシュ・シンボル lookup・差分・embedding) #204 のみ OPENgh issue list --label gwt-spec --state closed | grep -E '^(185|187|188|191|192)\b'— 5 件すべて CLOSEDgwtd issue spec 204 --section spec/plan/tasks/tdd— 全 4 section が取得できる (spec=body, tasks=body, plan=comment, tdd=comment)gwtd index rebuild --scope specs— SPEC index を再構築済み (documents=102)Closing Issues
Related Issues / Links
Checklist
tasks/lessons.mdのみの変更で cargo / clippy 対象外tasks/lessons.mdに例外条項を追記Context
unity-csharp-reference (UnityCsReference 参照キャッシュ) の SPEC は #185 (Phase 1) → #187 (Phase 2) → #188 (Phase 3) → #191 (Phase 4 umbrella) → #192 (Phase 4-B 誤起票) と Phase 単位で 5 件に分かれていた。他のドメイン SPEC (
gwt-spec: コンソール・プロジェクト設定(#154) やgwt-spec: C# LSP・コード編集(#153) など #146-#160) は ドメイン 1 件 = SPEC 1 件 で揃っているため、unity-csharp-reference だけ Phase / umbrella / 子 SPEC が混在していた状態を解消した。集約は GitHub Issue レイヤーで完結している:
gwt-speclabel のみ、gwtd issue spec create+--edit spec/plan/tasks/tdd)。Spec / Plan / Tasks / TDD section markers 投入済みgh issue close --reason 'not planned' --comment <consolidation-notice>で集約済み通知付き close本 PR のコード差分は
tasks/lessons.mdの 2 行のみ。SPEC 集約の運用ルール変更を将来の agent / user が再発見できるよう、tasks/lessons.mdの「gwt-spec を close しない」ルールに例外条項を追記している。