Skip to content

🐛 Add "controls" to amp-story-360 validator#30832

Merged
processprocess merged 2 commits intoampproject:masterfrom
processprocess:validator
Oct 23, 2020
Merged

🐛 Add "controls" to amp-story-360 validator#30832
processprocess merged 2 commits intoampproject:masterfrom
processprocess:validator

Conversation

@processprocess
Copy link
Contributor

Context / fixes #30831

@CLAassistant
Copy link

CLAassistant commented Oct 22, 2020

CLA assistant check
All committers have signed the CLA.

@amp-owners-bot
Copy link

Hey @gmajoulet, @t0mg! These files were changed:

extensions/amp-story-360/0.1/test/validator-amp-story-360.html
extensions/amp-story-360/0.1/test/validator-amp-story-360.out
extensions/amp-story-360/validator-amp-story-360.protoascii

@gmajoulet
Copy link
Contributor

cc @ampproject/wg-caching

@processprocess processprocess merged commit c34f4f0 into ampproject:master Oct 23, 2020
caoboxiao added a commit to caoboxiao/amphtml that referenced this pull request Oct 28, 2020
caoboxiao added a commit to caoboxiao/amphtml that referenced this pull request Oct 28, 2020
@caoboxiao caoboxiao mentioned this pull request Oct 28, 2020
caoboxiao added a commit that referenced this pull request Oct 29, 2020
* cl/338138658 Allow blurry image placeholders for Transformed AMP

* cl/338723089 Revision bump for #30832

* cl/338726670 Remove tailing whitespaces

* cl/339321880 Revision bump for #30847

* cl/339356382 Revision bump for #30869

Co-authored-by: honeybadgerdontcare <sedano@google.com>
@processprocess processprocess deleted the validator branch November 12, 2020 17:59
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* Add controls to validator.

* Alphabetize by attr name.
ed-bird pushed a commit to ed-bird/amphtml that referenced this pull request Dec 10, 2020
* cl/338138658 Allow blurry image placeholders for Transformed AMP

* cl/338723089 Revision bump for ampproject#30832

* cl/338726670 Remove tailing whitespaces

* cl/339321880 Revision bump for ampproject#30847

* cl/339356382 Revision bump for ampproject#30869

Co-authored-by: honeybadgerdontcare <sedano@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Story 360] controls is not a valid attribute

5 participants