remove unnecessary spec_name from script tagspecs#30847
Merged
honeybadgerdontcare merged 3 commits intoampproject:masterfrom Oct 26, 2020
Merged
remove unnecessary spec_name from script tagspecs#30847honeybadgerdontcare merged 3 commits intoampproject:masterfrom
honeybadgerdontcare merged 3 commits intoampproject:masterfrom
Conversation
|
|
amaltas
approved these changes
Oct 26, 2020
caoboxiao
added a commit
to caoboxiao/amphtml
that referenced
this pull request
Oct 28, 2020
Merged
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* unnecessary spec_name * Update validator-amp-ad.protoascii * Update validator-amp-video.protoascii
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* cl/338138658 Allow blurry image placeholders for Transformed AMP * cl/338723089 Revision bump for ampproject#30832 * cl/338726670 Remove tailing whitespaces * cl/339321880 Revision bump for ampproject#30847 * cl/339356382 Revision bump for ampproject#30869 Co-authored-by: honeybadgerdontcare <sedano@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TagSpecs with
tag_name: "SCRIPT"and having anextension_specwill have the validator automatically generate theirspec_namebased on the name within theextension_spec. See https://github.com/ampproject/amphtml/blob/master/validator/js/engine/validator.js#L5936With the coming of additional forms of extension scripts (e.g. module/nomodule), I'm cleaning these up.