CEA-708: Update current row value when new line is added

[dathdoan]

Update current row value when new line is added. This is to prevent an incorrect newline to be added in setPenLocation.

[icbaker]

Ah it looks like we previously merged the rowLock/columnLock fix (from you) in #942, and then it got accidentally reverted (by me) in dd2e4a5. I'm really sorry about that. As this part is more like a fix on top of dd2e4a5, rather than an 'original' change, I'm going to make this fix internally rather than directly merge this PR - the end result should be the same, but it will be a bit easier for me to tell the story of how this change ended up getting lost (for future code archaeologists). Hope that's OK!

I think 'Fix 2' in this PR wasn't part of #942 - so maybe you could update this PR to only contain 'Fix 2'?

[dathdoan]

Thanks, I've updated the PR title and the code changes to reflect the fix for fix 2 only.

[icbaker]

I've re-applied the rowLock/columnLock fix in e2847b3

[icbaker]

This is to prevent an incorrect newline to be added in setPenLocation.

Would you be able to provide a bit more info about this? Even better if you can craft a test case that demonstrates the issue that is fixed by this change.

In particular I'm trying to understand how this interacts with the existing this.row = row assignment in setPenLocation() - I wonder if this assignment should be removed as part of this change?

[dathdoan]

I've added a couple of test related to newline handling and setPenLocation. Essentially, without the fix, we get an extra newline in the output.

[icbaker]

I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks!