build: allow no-remote-exec targets to be cached on CI - #23789
Conversation
…nalysis cache Use renamed experimental_allow_tags_propagation instead of previous name (incompatible_allow_tags_propagation).
b5c91ea to
04c3297
Compare
jbedard
changed the title
| sudo bash -c "echo -e 'build --google_credentials=/home/circleci/.gcp_credentials' >> .bazelrc.user"; | ||
| # Upload/don't upload local results to cache based on environment | ||
| if [[ -n "{$CIRCLE_PULL_REQUEST}" ]]; then | ||
| sudo bash -c "echo -e 'build:remote --remote_upload_local_results=false\n' >> .bazelrc.user"; |
There was a problem hiding this comment.
Why was this done? Disabling remote caching for targets where remote execution is disabled...
Normally this would only be done for things like local dev to read but not write to the remote cache. I thought maybe it was to avoid polluting the cache server with random PRs but most bazel targets (all but 3 or 4) get executed remote and are cached despite this flag.
But this is what was causing a few of the unit tests and all the e2e tests (e2e being a WIP) to never be cached.
75b9726 to
727e633
Compare
alan-agius4
added
target: patch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
5 participants
No description provided.