Skip to content

build: allow no-remote-exec targets to be cached on CI #23789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
clydin merged 2 commits into from
Aug 29, 2022
Merged

build: allow no-remote-exec targets to be cached on CI #23789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e929f9f
build: always set bazel nolegacy_external_runfiles to avoid busting a…
jbedard Aug 24, 2022
727e633
build: allow no-remote-exec targets to be cached on CI
jbedard Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .bazelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@ build --symlink_prefix=dist/
build --nowatchfs

# Turn off legacy external runfiles
run --nolegacy_external_runfiles
test --nolegacy_external_runfiles
build --nolegacy_external_runfiles
Comment thread
devversion marked this conversation as resolved.

# Turn on --incompatible_strict_action_env which was on by default
# in Bazel 0.21.0 but turned off again in 0.22.0. Follow
Expand All @@ -51,7 +50,7 @@ test --incompatible_strict_action_env
build --experimental_remote_merkle_tree_cache

# Ensure that tags applied in BUILDs propagate to actions
build --incompatible_allow_tags_propagation
build --experimental_allow_tags_propagation
Comment thread
devversion marked this conversation as resolved.

# Don't check if output files have been modified
build --noexperimental_check_output_files
Expand Down
8 changes: 0 additions & 8 deletions .circleci/dynamic_config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,14 +136,6 @@ commands:
# cause decryption failures based on the openssl version. https://stackoverflow.com/a/39641378/4317734
openssl aes-256-cbc -d -in .circleci/gcp_token -md md5 -k "${<< parameters.key >>}" -out /home/circleci/.gcp_credentials;
sudo bash -c "echo -e 'build --google_credentials=/home/circleci/.gcp_credentials' >> .bazelrc.user";
# Upload/don't upload local results to cache based on environment
if [[ -n "{$CIRCLE_PULL_REQUEST}" ]]; then
sudo bash -c "echo -e 'build:remote --remote_upload_local_results=false\n' >> .bazelrc.user";

@jbedard jbedard Aug 25, 2022

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this done? Disabling remote caching for targets where remote execution is disabled...

Normally this would only be done for things like local dev to read but not write to the remote cache. I thought maybe it was to avoid polluting the cache server with random PRs but most bazel targets (all but 3 or 4) get executed remote and are cached despite this flag.

But this is what was causing a few of the unit tests and all the e2e tests (e2e being a WIP) to never be cached.

echo "Not uploading local build results to remote cache.";
else
sudo bash -c "echo -e 'build:remote --remote_upload_local_results=true\n' >> .bazelrc.user";
echo "Uploading local build results to remote cache.";
fi
# Enable remote builds
sudo bash -c "echo -e 'build --config=remote' >> .bazelrc.user";
echo "Reading from remote cache for bazel remote jobs.";
Expand Down
2 changes: 0 additions & 2 deletions packages/angular_devkit/core/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,6 @@ ts_library(
jasmine_node_test(
name = "core_test_" + toolchain_name,
srcs = [":core_test_lib"],
# TODO: Audit tests to determine if tests can be run in RBE environments
local = True,
toolchain = toolchain,
deps = [
# @node_module: ajv
Expand Down