Skip to content

build: use npm5 instead of yarn - #7060

Merged
filipesilva merged 1 commit into
angular:masterfrom
filipesilva:package-lock
Aug 1, 2017
Merged

build: use npm5 instead of yarn#7060
filipesilva merged 1 commit into
angular:masterfrom
filipesilva:package-lock

Conversation

@filipesilva

Copy link
Copy Markdown
Contributor

No description provided.

@filipesilva
filipesilva force-pushed the package-lock branch 3 times, most recently from adfe40a to 13d8d25 Compare July 20, 2017 13:21
@ishitatsuyuki

Copy link
Copy Markdown
Contributor

npm5 is not faster than yarn, and I have heard that it can be buggy in some cases. I would recommend staying with yarn.

@filipesilva

Copy link
Copy Markdown
Contributor Author

I agree with you that it's not faster, and that there are bugs. But the reason for moving isn't so much the speed, but the interop.

Right now it's pretty painful to develop with a linked cli and npm5. You need to npm link && rm -rf node_modules/ && yarn on the CLI dir. And then on the linked project, linking and then installing something else will break the modules as well. This is very frustrating as a CLI dev.

Another factor is that even though the CLI itself uses yarn, when in our e2e tests we use npm to ensure compatibility with most users. So using npm everywhere also has benefits.

It also helps that package-lock.json is pretty decent, and that it doesn't depend on the package manager version like yarn does.

Overall I do expect package-lock.json to become the standard.

@filipesilva
filipesilva force-pushed the package-lock branch 2 times, most recently from 12992ad to f232466 Compare July 24, 2017 14:49
@filipesilva filipesilva reopened this Jul 24, 2017
@filipesilva
filipesilva force-pushed the package-lock branch 3 times, most recently from b70cf2d to 3a64593 Compare July 26, 2017 16:12
@filipesilva
filipesilva force-pushed the package-lock branch 2 times, most recently from 4007aea to 3d070a3 Compare July 31, 2017 15:01
@filipesilva
filipesilva requested a review from hansl July 31, 2017 18:05
Brocco
Brocco previously approved these changes Jul 31, 2017

@hansl hansl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipesilva
filipesilva merged commit b98bf2f into angular:master Aug 1, 2017
@filipesilva
filipesilva deleted the package-lock branch August 1, 2017 19:41
@diagramatics

Copy link
Copy Markdown
Contributor

So bringing this topic back up again, I noticed Angular's now switched to Yarn with angular/angular#19328. Is the team's stance changing again?

@filipesilva

Copy link
Copy Markdown
Contributor Author

No plan to change at the moment, no.

@angular-automatic-lock-bot

Copy link
Copy Markdown

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants