fix(@angular/cli): fix empty 3rdpartylicenses.txt - #7064
Merged
Conversation
filipesilva
previously approved these changes
Jul 31, 2017
filipesilva
left a comment
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
Heya @xz64, thanks for fixing this issue and submitting the update here. Can you rebase please? It took us a while to review this Pr and meanwhile other dependencies changed.
Contributor
Author
|
Hi @filipesilva, I have rebased the branch. |
Contributor
filipesilva
previously approved these changes
Aug 2, 2017
Upgrades license-webpack-plugin from 0.4.x to 0.5.x. Closes #6921
Contributor
Author
|
It is rebased now, without a yarn.lock file. |
filipesilva
approved these changes
Aug 4, 2017
Contributor
|
It's in now, thanks again for your work @xz64 👍 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrades license-webpack-plugin from 0.4.x to 0.5.x.
Closes #6921