fix(@angular/cli): ensure asset output is within the output path - #7778
Merged
Conversation
clydin
force-pushed
the
restrict-asset-output-path
branch
from
September 21, 2017 23:11
fe7947e to
540cf84
Compare
filipesilva
approved these changes
Sep 25, 2017
filipesilva
left a comment
filipesilva
left a comment
Contributor
There was a problem hiding this comment.
Agree, this is causing silent problems in a bunch of setups.
1 task
hansl
added a commit
to hansl/angular-cli
that referenced
this pull request
Oct 20, 2017
hansl
added a commit
to hansl/angular-cli
that referenced
this pull request
Oct 22, 2017
hansl
added a commit
to hansl/angular-cli
that referenced
this pull request
Nov 16, 2017
hansl
added a commit
that referenced
this pull request
Nov 20, 2017
hansl
added a commit
that referenced
this pull request
Nov 23, 2017
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build output should be sandboxed within the specified output path. It's currently quite easy to unintentionally (or the remote chance of maliciously) cause an asset or assets to be written to a location on the filesystem outside the project itself.