fix(@angular/cli): add a flag to let assets outside of outDir - #8123
Conversation
filipesilva
left a comment
There was a problem hiding this comment.
WDYT of having the flag directly on the asset object definition? #8122 (comment)
filipesilva
left a comment
There was a problem hiding this comment.
Can you add a test that ensures this works?
filipesilva
left a comment
There was a problem hiding this comment.
Docs should also be added in https://github.com/angular/angular-cli/blob/master/docs/documentation/stories/asset-configuration.md
This is a security risk. Think reading things from the home directory.
|
@filipesilva PTAL. |
|
So the whole project cannot be built outside anymore (using |
|
@BnSmth, I'm not talking about assets. Instead about entire application. That change in #7778 only checks the asset paths against Simple steps to reproduce:
Do that with both cli versions and you will see in If this was not intentional then I'll create an issue. |
|
@dzonatan Sorry, my bad. I misunderstood the issue and agree that a fix needs to be put in place. Also, as you said, given this is a breaking change, a note should have been added to the release. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
On top of #7778
Fixes #8122