docs: update documentation for universal by MarkPieszak · Pull Request #7796 · angular/angular-cli

MarkPieszak · 2017-09-23T00:01:04Z

Closes #7706
Closes #7248

Can close PR #7739

Toxicable · 2017-09-23T00:54:46Z

+// * NOTE :: leave this as require() since this file is built Dynamically from webpack
+const { AppServerModuleNgFactory, LAZY_MODULE_MAP } = require('./dist/server/main.bundle');
+
+const { provideModuleMap } = require('@nguniversal/module-map-ngfactory-loader');


should include installation of this package in the installation section.

Toxicable · 2017-09-23T00:55:25Z


-// Import renderModuleFactory from @angular/platform-server.
-var renderModuleFactory = require('@angular/platform-server').renderModuleFactory;
+// ALl regular routes use the Universal engine


Toxicable · 2017-09-23T00:58:33Z

-var renderModuleFactory = require('@angular/platform-server').renderModuleFactory;
+// ALl regular routes use the Universal engine
+app.get('*', (req, res) => {
+  res.render('index', { req });


This assumes you're running the server.js in the same folder as your index.html yet below we describe using dist/browser, maybe sync those up?

You don't need directory stuff here, we are just calling the engine here

I meant the .render('index' dosen't that look for index.html in the directory it's being executed in?

It has reference to it, since it's a lookup of the View, so having just index alone works since it knows which oneto find. You can be explicit and do res.render(join(DIST_FOLDER, 'browser', 'index.html'), { req }); but there's no need. ExpressEngines are almost always just a string like this one.

Toxicable · 2017-09-23T01:01:55Z

+});
+```
+
+## Step 5: Setup a webpack config to handle this Node server.ts file and serve your application!


Mention that this is work around for #7200 ?
It makes sense for the dynamic case since you shouldn't have to do a npm install on your server, but for static not so much (if #7200 wasn't an issue)

Yeah I'll put that in there, good idea! Forgot the issue number 👍

hansl · 2017-09-23T04:14:53Z

You will want to remove the universal part of your commits (put it in the title please). So basically something like docs: update documentation for universal. And it seems like 3 commits are a bit much; is it really 3 pieces of work?

Aside from the cosmetic part, I'll let the Universal team review this PR.

CaerusKaru · 2017-09-23T09:15:15Z

@MarkPieszak Can you provide at least some notes about the webpack warnings that arise? Perhaps mention the partial solution given by @gdi2290 at angular/angular#11580 (comment)

E.g.

WARNING in ./node_modules/@angular/core/@angular/core.es5.js
5675:15-102 Critical dependency: the request of a dependency is an expression

It may warrant further discussion since these issues crop up with a lot of express dependencies, e.g. express itself, shrink-wrap, etc

MarkPieszak · 2017-09-23T12:44:12Z

Thanks @hans, will make some updates & squash the commits. 👍
@CaerusKaru Added a note to it and included it in the webpack.server.config.js file as well, to avoid the issue for people completely (i'll update the universal-starter / cli with this as well) :)

docs(universal): updates remove duplicate universal-starter link pick pocs: update with changes requested

…ular-cli into universal-readme

docs(universal): updates remove duplicate universal-starter link pick pocs: update with changes requested docs(universal): updates remove duplicate universal-starter link docs: update with changes requested update views dist_folder

…ular-cli into universal-readme

MarkPieszak · 2017-09-23T20:31:58Z

Closing for PR #7803 as history got out of control on this one.

angular-automatic-lock-bot · 2019-09-12T04:41:30Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

MarkPieszak added 2 commits September 22, 2017 19:48

docs(universal): update docs

68d585a

docs(universal): updates

0cea1fe

googlebot added the cla: yes label Sep 23, 2017

MarkPieszak mentioned this pull request Sep 23, 2017

docs: Update Universal Story to include module map #7739

Closed

remove duplicate universal-starter link

70d814a

Toxicable reviewed Sep 23, 2017

View reviewed changes

MarkPieszak changed the title ~~docs(universal-rendering): update to use typescript and webpack~~ docs: update documentation for universal Sep 23, 2017

MarkPieszak added 6 commits September 23, 2017 08:50

docs: update with changes requested

de27c0e

docs(universal): update docs

667630a

docs(universal): updates remove duplicate universal-starter link pick pocs: update with changes requested

Merge branch 'universal-readme' of https://github.com/MarkPieszak/ang…

cc8d792

…ular-cli into universal-readme

update views dist_folder

e3e5ff0

docs(universal): update docs

b5a107e

docs(universal): updates remove duplicate universal-starter link pick pocs: update with changes requested docs(universal): updates remove duplicate universal-starter link docs: update with changes requested update views dist_folder

Merge branch 'universal-readme' of https://github.com/MarkPieszak/ang…

b4fadae

…ular-cli into universal-readme

MarkPieszak mentioned this pull request Sep 23, 2017

docs: update documentation for universal #7803

Merged

MarkPieszak closed this Sep 23, 2017

MarkPieszak deleted the universal-readme branch September 23, 2017 20:32

angular-automatic-lock-bot Bot locked and limited conversation to collaborators Sep 12, 2019

Uh oh!

Conversation

MarkPieszak commented Sep 23, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hansl commented Sep 23, 2017

Uh oh!

CaerusKaru commented Sep 23, 2017

Uh oh!

MarkPieszak commented Sep 23, 2017

Uh oh!

MarkPieszak commented Sep 23, 2017

Uh oh!

angular-automatic-lock-bot Bot commented Sep 12, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants