docs: update documentation for universal - #7803
Merged
Merged
Conversation
Contributor
|
I'll wait for @vikerman 's approval before merging this, but LGTM. |
vikerman
suggested changes
Oct 6, 2017
|
|
||
| * Lazy loading is not yet supported, but coming very soon. Currently lazy loaded routes aren't available for prerendering, and you will get a `System is not defined` error. | ||
| * The bundle produced has a hash in the filename from webpack. When deploying this to a production server, you will need to ensure the correct bundle is required, either by renaming the file or passing the bundle name as an argument to your server. No newline at end of file | ||
| - Http calls will be executed **twice** |
Contributor
There was a problem hiding this comment.
I don't think this is the place to mention all of Universal Gotchas. We should just mention any Universal CLI gotchas if any,
vikerman
approved these changes
Oct 6, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replacement for PR #7796
Update documentation to show TypeScript webpack build for node server, as well as a few gotchas & important things to have setup to have it bundle normal applications properly.
cc/ @vikerman