refactor: move all CLI-specific exceptions to different options - #7981
Merged
Conversation
hansl
added a commit
to hansl/devkit
that referenced
this pull request
Oct 9, 2017
This is supposed to be released at the same time as angular/angular-cli#7981
hansl
added a commit
to hansl/devkit
that referenced
this pull request
Oct 9, 2017
This is supposed to be released at the same time as angular/angular-cli#7981
hansl
added a commit
to hansl/devkit
that referenced
this pull request
Oct 9, 2017
This is supposed to be released at the same time as angular/angular-cli#7981
hansl
added a commit
to hansl/devkit
that referenced
this pull request
Oct 9, 2017
This is supposed to be released at the same time as angular/angular-cli#7981
hansl
added a commit
to angular/devkit
that referenced
this pull request
Oct 9, 2017
This is supposed to be released at the same time as angular/angular-cli#7981
hansl
force-pushed
the
schematics-args
branch
4 times, most recently
from
October 9, 2017 23:43
85eef76 to
b9a18c1
Compare
We made too many shortcuts for passing data in and custom schematics could not work properly. This is temporary as we will likely move some more logic into schematics tooling to be able to pass only the raw args and the CLI config, but for now this is enough to unblock AngularMix.
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
…lar#7981) We made too many shortcuts for passing data in and custom schematics could not work properly. This is temporary as we will likely move some more logic into schematics tooling to be able to pass only the raw args and the CLI config, but for now this is enough to unblock AngularMix.
dond2clouds
pushed a commit
to d2clouds/speedray-cli
that referenced
this pull request
Apr 23, 2018
…ons (angular#7981)" This reverts commit ae47b46.
hansl
added a commit
that referenced
this pull request
Jun 6, 2018
This is supposed to be released at the same time as #7981
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We made too many shortcuts for passing data in and custom schematics could not
work properly.
This is temporary as we will likely move some more logic into schematics tooling
to be able to pass only the raw args and the CLI config, but for now this is
enough to unblock AngularMix.