This repository was archived by the owner on Sep 5, 2024. It is now read-only.
fix(menuBar): md-menu-bar panel theme supports dark mode#11258
Merged
Conversation
googlebot
added
the
cla: yes
rudzikdawid
force-pushed
the
fixMenuBarTheme
branch
from
6a64cc8 to
359b917
Compare
Splaktar
added
ui: theme
type: bug
P4: minor
Splaktar
suggested changes
Apr 26, 2018
Contributor
Splaktar
left a comment
Splaktar
left a comment
There was a problem hiding this comment.
Looks good. Just a minor change needed for md-toolbar-filler. This actually helped me look at this feature and figure it out better. I'll be opening a PR to re-add it to the menuBar docs and to add it to the toolbar docs.
| md-toolbar-filler { | ||
| background-color: '{{primary-color}}'; | ||
| color: '{{background-A100-0.87}}'; | ||
| color: '{{foreground-1}}'; |
Contributor
There was a problem hiding this comment.
Please use '{{primary-contrast}}' here.
| color: '{{foreground-1}}'; | ||
| md-icon { | ||
| color: '{{background-A100-0.87}}'; | ||
| color: '{{foreground-2}}'; |
Contributor
There was a problem hiding this comment.
Please use '{{primary-contrast}}' here.
Contributor
|
Currently: With Opened #11260 with the |
Splaktar
added
the
in progress
Splaktar
added a commit
that referenced
this pull request
Apr 26, 2018
register the icon sets in the docs app fix strange absolute styling alignment issue Relates to #11258
3 tasks
rudzikdawid
force-pushed
the
fixMenuBarTheme
branch
from
359b917 to
4396a2a
Compare
andrewseguin
pushed a commit
that referenced
this pull request
Apr 26, 2018
register the icon sets in the docs app fix strange absolute styling alignment issue Relates to #11258
rudzikdawid
force-pushed
the
fixMenuBarTheme
branch
2 times, most recently
from
b389826 to
5ab683d
Compare
rudzikdawid
force-pushed
the
fixMenuBarTheme
branch
from
5ab683d to
7aa9e2e
Compare
Splaktar
approved these changes
Apr 27, 2018
Splaktar
added
pr: merge ready
Splaktar
added a commit
that referenced
this pull request
Jul 31, 2018
register the icon sets in the docs app fix strange absolute styling alignment issue Relates to #11258
Splaktar
pushed a commit
that referenced
this pull request
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #11238
PR Checklist
Please check that your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The
md-menu-barpanel is partially using light mode hues in dark mode.Issue Number:
Fixes #11238.
What is the new behavior?
The
md-menu-barpanel use dark mode hues when the theme is set to dark mode.Does this PR introduce a breaking change?
Other information
dark mode before:
dark mode after:
light mode before:
light mode after:
