Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

docs(toolbar,menuBar): add md-toolbar-filler examples#11260

Merged
andrewseguin merged 1 commit into
masterfrom
mdToolbarFillterDocs
Apr 26, 2018
Merged

docs(toolbar,menuBar): add md-toolbar-filler examples#11260
andrewseguin merged 1 commit into
masterfrom
mdToolbarFillterDocs

Conversation

@Splaktar
Copy link
Copy Markdown
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

The md-toolbar-filler examples for md-menu-bar were removed because the icons were broken.
There are no examples of using md-toolbar-filler with md-toolbar.

This was found with the review of #11258.

Issue Number:
Relates to #11258

What is the new behavior?

Re-added the md-toolbar-filler examples for md-menu-bar with fixed icons.
Added a md-toolbar-filler example to the Toolbar Basic Demo.
removed some unneeded icons (they are already in docs/app/img/icons/.
register the icon sets in the docs app
fix strange absolute styling alignment issue

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

N/A

register the icon sets in the docs app
fix strange absolute styling alignment issue

Relates to #11258
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Apr 26, 2018
@Splaktar Splaktar added this to the 1.1.9 milestone Apr 26, 2018
@Splaktar Splaktar added type: demos P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review pr: merge safe labels Apr 26, 2018
@Splaktar
Copy link
Copy Markdown
Contributor Author

MenuBar:
screen shot 2018-04-26 at 1 15 27 am

Toolbar:
screen shot 2018-04-26 at 1 36 32 am

@andrewseguin andrewseguin merged commit f6bdc05 into master Apr 26, 2018
@Splaktar Splaktar deleted the mdToolbarFillterDocs branch April 27, 2018 06:24
Splaktar added a commit that referenced this pull request Jul 31, 2018
register the icon sets in the docs app
fix strange absolute styling alignment issue

Relates to #11258
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P4: minor Minor issues. May not be fixed without community contributions. pr: merge ready This PR is ready for a caretaker to review type: demos

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants