Use INumberBase<T>.CreateChecked on .NET 7+#1518
Merged
angularsen merged 5 commits intoMar 4, 2025
Merged
Conversation
Collaborator
|
I don't personally use these extensions, but here are a few more remarks:
|
…m to any issue with `<Nullable>enable</Nullable>`and `<LangVersion>latest</LangVersion>`.
Contributor
Author
|
Using IConvertible does avoid the boxing, which is nice. |
lipchev
approved these changes
Feb 27, 2025
Collaborator
lipchev
left a comment
There was a problem hiding this comment.
LGTM
Hopefully, one day we would be able to add the properties here as well..
Owner
|
Looks good to me also, thanks! @lipchev you can also merge PRs by the way unless you want a pair of extra eyes on it. |
Collaborator
|
@angularsen I know, but I didn't know how you want to handle the release of this one, and the merging of the changes between |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing change suggested in #1483 .