Skip to content

fix: use correct denom calc for osmosis swaps#4582

Merged
mergify[bot] merged 4 commits intomainfrom
mat/use-correct-ibc-denom-calc
Apr 23, 2025
Merged

fix: use correct denom calc for osmosis swaps#4582
mergify[bot] merged 4 commits intomainfrom
mat/use-correct-ibc-denom-calc

Conversation

@mateuszjasiuk
Copy link
Copy Markdown
Contributor

Describe your changes

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes
  • If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
    • Relevant PR if applies:
  • If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
    • Relevant PR if applies:

@github-actions github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Apr 17, 2025
sug0 added a commit that referenced this pull request Apr 22, 2025
sug0 added a commit that referenced this pull request Apr 22, 2025
@sug0 sug0 force-pushed the mat/use-correct-ibc-denom-calc branch from d89f0be to 5103483 Compare April 22, 2025 12:10
@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Apr 22, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Apr 22, 2025
@sug0 sug0 removed breaking:api public API breaking change merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass labels Apr 22, 2025
@github-actions github-actions bot added the breaking:api public API breaking change label Apr 22, 2025
sug0 added a commit that referenced this pull request Apr 22, 2025
@sug0 sug0 force-pushed the mat/use-correct-ibc-denom-calc branch from 44c9bce to d88ae33 Compare April 22, 2025 14:23
@sug0 sug0 force-pushed the mat/use-correct-ibc-denom-calc branch from d88ae33 to f7e2fd5 Compare April 22, 2025 14:39
@sug0 sug0 added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Apr 23, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (730b03c) to head (f7e2fd5).
Report is 14 commits behind head on main.

Additional details and impacted files
@@     Coverage Diff      @@
##   main   #4582   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sug0 sug0 added breaking:api public API breaking change breaking:SDK SDK breaking change and removed breaking:api public API breaking change labels Apr 23, 2025
mergify bot added a commit that referenced this pull request Apr 23, 2025
mergify bot added a commit that referenced this pull request Apr 23, 2025
mergify bot added a commit that referenced this pull request Apr 23, 2025
mergify bot added a commit that referenced this pull request Apr 23, 2025
mergify bot added a commit that referenced this pull request Apr 23, 2025
@mergify mergify bot merged commit f50f7d1 into main Apr 23, 2025
28 checks passed
@mergify mergify bot deleted the mat/use-correct-ibc-denom-calc branch April 23, 2025 09:34
mergify bot pushed a commit that referenced this pull request Apr 23, 2025
(cherry picked from commit f7e2fd5)
mergify bot added a commit that referenced this pull request Apr 23, 2025
fix: use correct denom calc for osmosis swaps (backport #4582)
tzemanovic added a commit that referenced this pull request Jun 4, 2025
Namada libs-v0.150.0

* tag 'libs-v0.150.0':
  Changelog: Release libs 0.150.0
  Namada libs 0.150.0
  changelog: add #4666
  added changelog
  add more tests
  fixes from reviews
  fixes from reviews
  test/pos: claim optimizations
  PoS: optimize claim rewards
  add pgf test
  add governance test
  pgf/governance disallow non-native transfers
  Changelog for #4659
  Change nomenclature of transfer in/out validation fn
  Soft limit the number of wasm transfer targets
  Adds masp integration test for multi-input notes
  Dont construct a shielded component when the transfer data is completely transparent.
  Added a changelog entry.
  Renamed structures to increase clarity.
  Combined transfer inputs and outputs.
  Refactors extraction of fee payer from `SigingTxData`
  Also write epoch migrations directly into memory.
  Added a changelog entry.
  Added a changelog entry.
  Demonstrate accelerating epochs.
  Added a migration that sets the shielded reward parameters of specified tokens.
  Added a changelog entry.
  Slow down the epochs in tricky_masp_txs.
  Increased the usage of constants in migrations.
  Allow denomination to be specified separately for each token.
  Fixes handling of serialized signatures
  Changelog #4625
  Merges the disposable gas payer flag into `fee_payer`
  Improves conflicts and requirements in cli args for `TxCustom`
  Merges fee payer and wrapper signature into a single field of `SigningTxData`
  Moves signatures and wrapper signature into `SigningTxData`
  Moves `signatures` and `wrapper_signature` args from `Tx` to `TxCustom`
  Improves cli help messages for signers/fee payers
  Changelog #4619
  Defers saving disposable gas payer to the wallet right before tx submission
  Removes `--disposable-gas-payer` arg
  Adds warning messages for transparent fee payment in masp transaction. Adds conflict between the disposable gas payer argument and the signing keys one.
  Updates help message for `gas-spending-key`
  Mandatory source in `MaspTargetTransferData`
  Implied gas spending key
  Changelog #4579
  Derive `PartialEq` for `SigningTxData`
  Makes the public keys for signing unique
  Tests expected commtiment tree in masp event test
  ci/can-backport: set semver baseline-root to current maint branch
  Changelog for #4582
  Fix shielded swaps SQS queries
  Improve docstr
  fix: use correct denom calc for osmosis swaps
  Changelog for #4594
  Delete IBC signer parsing as gov addr dead code
  ci: use nextest to run hardwallet e2e tests
  ci: use nextest to run hardwallet e2e tests
  changelog
  update hermes
  test/e2e: auto cleanup speculos process
  Changelog for #4580
  Change ABI to C-unwind in vm_env when running natively
  test/e2e: hw-wallet-automation - try to disable speculos REST API
  Changelog #4566
  Adds failing atomic batch fee payment integration test
  Filters only tx result events in integration tests
  Extends masp events integration test
  Adds masp events integration test
  fix core release by symlinking CONSENSUS_VERSION
  CI: bump maint version libs-v0.49 and apps-101.0
  Refactors masp event lookup
  Fixed top-level comments.
  Changelog #4544
  Masp fee payment msg in `display_batch_resp`
  Added a changelog entry.
  Allow migrations to reset the conversions for arbitrary Namada addresses.
  Added a changelog entry.
  Implemented logic to update transaction WASMs in hard-fork migration.
  Changelog for #4541
  Improve MASP fee payment VP errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-libs-0.251 Backport libraries to 0.251 maintenance branch breaking:api public API breaking change breaking:SDK SDK breaking change bug Something isn't working client merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass non-breaking-change SDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants