optimize claim rewards tx by tzemanovic · Pull Request #4666 · namada-net/namada

tzemanovic · 2025-06-02T12:20:06Z

Describe your changes

Checklist before merging

If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
- This will require 2 reviewers to approve the changes
If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
- Relevant PR if applies:
If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
- Relevant PR if applies:

codecov · 2025-06-02T12:53:23Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (733d6b0) to head (237c45e).
Report is 95 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #4666   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

tzemanovic · 2025-06-02T14:28:36Z

crates/proof_of_stake/src/lib.rs

                })
+                .cloned()
                // ... and add `list_slashes`
-                .chain(list_slashes.iter().cloned())


note that this is cloning the iterator, not the slashes

tzemanovic · 2025-06-02T14:29:24Z

crates/proof_of_stake/src/lib.rs

                    ) && *bond_start <= slash.epoch
                        && slash_epoch_filter(slash.epoch)
                })
+                .cloned()


I tried to get rid of these clones, but because of the explicit lifetime on the list_slashes iter items I couldn't get it to lifetime-check on chain(list_slashes)

mergify · 2025-06-04T09:21:10Z

This pull request has been removed from the queue for the following reason: pull request dequeued.

Pull request #4666 has been dequeued. The pull request rule doesn't match anymore. The following conditions don't match anymore:

label = "merge".

You can check the last failing draft PR here: #4672.

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.
If you do update this pull request, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify · 2025-06-04T09:21:38Z

Hey @tzemanovic, your pull request has been dequeued due to the following reason: PR_DEQUEUED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

tzemanovic · 2025-06-04T09:22:51Z

@Mergifyio requeue

mergify · 2025-06-04T09:23:07Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

(cherry picked from commit 237c45e)

optimize claim rewards tx (backport #4666)

Namada libs-v0.150.0 * tag 'libs-v0.150.0': Changelog: Release libs 0.150.0 Namada libs 0.150.0 changelog: add #4666 added changelog add more tests fixes from reviews fixes from reviews test/pos: claim optimizations PoS: optimize claim rewards add pgf test add governance test pgf/governance disallow non-native transfers Changelog for #4659 Change nomenclature of transfer in/out validation fn Soft limit the number of wasm transfer targets Adds masp integration test for multi-input notes Dont construct a shielded component when the transfer data is completely transparent. Added a changelog entry. Renamed structures to increase clarity. Combined transfer inputs and outputs. Refactors extraction of fee payer from `SigingTxData` Also write epoch migrations directly into memory. Added a changelog entry. Added a changelog entry. Demonstrate accelerating epochs. Added a migration that sets the shielded reward parameters of specified tokens. Added a changelog entry. Slow down the epochs in tricky_masp_txs. Increased the usage of constants in migrations. Allow denomination to be specified separately for each token. Fixes handling of serialized signatures Changelog #4625 Merges the disposable gas payer flag into `fee_payer` Improves conflicts and requirements in cli args for `TxCustom` Merges fee payer and wrapper signature into a single field of `SigningTxData` Moves signatures and wrapper signature into `SigningTxData` Moves `signatures` and `wrapper_signature` args from `Tx` to `TxCustom` Improves cli help messages for signers/fee payers Changelog #4619 Defers saving disposable gas payer to the wallet right before tx submission Removes `--disposable-gas-payer` arg Adds warning messages for transparent fee payment in masp transaction. Adds conflict between the disposable gas payer argument and the signing keys one. Updates help message for `gas-spending-key` Mandatory source in `MaspTargetTransferData` Implied gas spending key Changelog #4579 Derive `PartialEq` for `SigningTxData` Makes the public keys for signing unique Tests expected commtiment tree in masp event test ci/can-backport: set semver baseline-root to current maint branch Changelog for #4582 Fix shielded swaps SQS queries Improve docstr fix: use correct denom calc for osmosis swaps Changelog for #4594 Delete IBC signer parsing as gov addr dead code ci: use nextest to run hardwallet e2e tests ci: use nextest to run hardwallet e2e tests changelog update hermes test/e2e: auto cleanup speculos process Changelog for #4580 Change ABI to C-unwind in vm_env when running natively test/e2e: hw-wallet-automation - try to disable speculos REST API Changelog #4566 Adds failing atomic batch fee payment integration test Filters only tx result events in integration tests Extends masp events integration test Adds masp events integration test fix core release by symlinking CONSENSUS_VERSION CI: bump maint version libs-v0.49 and apps-101.0 Refactors masp event lookup Fixed top-level comments. Changelog #4544 Masp fee payment msg in `display_batch_resp` Added a changelog entry. Allow migrations to reset the conversions for arbitrary Namada addresses. Added a changelog entry. Implemented logic to update transaction WASMs in hard-fork migration. Changelog for #4541 Improve MASP fee payment VP errors

tzemanovic added 2 commits June 2, 2025 13:17

PoS: optimize claim rewards

4625b41

test/pos: claim optimizations

f865c56

tzemanovic marked this pull request as ready for review June 2, 2025 12:20

github-actions bot added the backport-libs-0.251 Backport libraries to 0.251 maintenance branch label Jun 2, 2025

tzemanovic mentioned this pull request Jun 2, 2025

add update-tx-claim-rewards-2 namada-net/namada-governance-upgrades#48

Closed

tzemanovic requested review from Fraccaman and brentstone June 2, 2025 14:27

tzemanovic commented Jun 2, 2025

View reviewed changes

brentstone approved these changes Jun 4, 2025

View reviewed changes

brentstone added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jun 4, 2025

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #4666

e68a09f

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking main (b4486cf) and #4666 together #4672

Closed

tzemanovic removed the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jun 4, 2025

changelog: add #4666

237c45e

tzemanovic added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label Jun 4, 2025

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge of #4666

ed594e0

mergify bot mentioned this pull request Jun 4, 2025

merge queue: embarking main (b4486cf), #4555 and #4666 together #4674

Closed

mergify bot merged commit a6dd871 into main Jun 4, 2025
26 checks passed

mergify bot deleted the tomas/optimize-claim-rewards branch June 4, 2025 10:49

mergify bot pushed a commit that referenced this pull request Jun 4, 2025

changelog: add #4666

520f434

(cherry picked from commit 237c45e)

mergify bot mentioned this pull request Jun 4, 2025

optimize claim rewards tx (backport #4666) #4676

Merged

3 tasks

mergify bot added a commit that referenced this pull request Jun 4, 2025

Merge pull request #4676 from anoma/mergify/bp/maint-libs-0.149/pr-4666

00fbd3c

optimize claim rewards tx (backport #4666)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

optimize claim rewards tx#4666

optimize claim rewards tx#4666
mergify[bot] merged 3 commits intomainfrom
tomas/optimize-claim-rewards

tzemanovic commented Jun 2, 2025

Uh oh!

codecov bot commented Jun 2, 2025 •

edited

Loading

Uh oh!

tzemanovic Jun 2, 2025

Uh oh!

tzemanovic Jun 2, 2025

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

tzemanovic commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

tzemanovic commented Jun 2, 2025

Describe your changes

Checklist before merging

Uh oh!

codecov bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

tzemanovic Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

tzemanovic Jun 2, 2025

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 4, 2025

Uh oh!

tzemanovic commented Jun 4, 2025

Uh oh!

mergify bot commented Jun 4, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

codecov bot commented Jun 2, 2025 •

edited

Loading