Improve shielded fee payment UX by grarco · Pull Request #4619 · namada-net/namada

grarco · 2025-04-29T08:24:03Z

Describe your changes

Closes #3964.

the gas-spending-key argument is now implied to be the first source of the tx when not provided
removed the --disposable-gas-payer argument which is now consider the default (the user can always override it by providing a transparent --gas-payer or --signing-keys)
the saving of the disposable gas payer keys in the wallet has been deferred to right before the tx's submission (in case of previous errors during the build process saving the key in the wallet is useless)

Checklist before merging

If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
- This will require 2 reviewers to approve the changes
If this PR requires changes to the docs or specs, a corresponding PR is opened in the namada-docs repo
- Relevant PR if applies: Update fee docs namada-docs#443
If this PR affects services such as namada-indexer or namada-masp-indexer, a corresponding PR is opened in that repo
- Relevant PR if applies:

…. Adds conflict between the disposable gas payer argument and the signing keys one.

…ission

brentstone

Thx, I like these changes

codecov · 2025-05-26T08:20:45Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (c2cddf3) to head (a0cfbc8).
Report is 29 commits behind head on main.

Additional details and impacted files

@@     Coverage Diff      @@
##   main   #4619   +/-   ##
============================
============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

mergify · 2025-05-26T08:27:42Z

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

❌ lints

You can check the last failing draft PR here: #4648.

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

mergify · 2025-05-26T08:28:15Z

Hey @grarco, your pull request has been dequeued due to the following reason: CHECKS_FAILED.
Sorry about that, but you can requeue the PR by using @mergifyio requeue if you think this was a mistake.

grarco · 2025-05-26T10:01:22Z

@Mergifyio requeue

mergify · 2025-05-26T10:01:29Z

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Namada libs-v0.150.0 * tag 'libs-v0.150.0': Changelog: Release libs 0.150.0 Namada libs 0.150.0 changelog: add #4666 added changelog add more tests fixes from reviews fixes from reviews test/pos: claim optimizations PoS: optimize claim rewards add pgf test add governance test pgf/governance disallow non-native transfers Changelog for #4659 Change nomenclature of transfer in/out validation fn Soft limit the number of wasm transfer targets Adds masp integration test for multi-input notes Dont construct a shielded component when the transfer data is completely transparent. Added a changelog entry. Renamed structures to increase clarity. Combined transfer inputs and outputs. Refactors extraction of fee payer from `SigingTxData` Also write epoch migrations directly into memory. Added a changelog entry. Added a changelog entry. Demonstrate accelerating epochs. Added a migration that sets the shielded reward parameters of specified tokens. Added a changelog entry. Slow down the epochs in tricky_masp_txs. Increased the usage of constants in migrations. Allow denomination to be specified separately for each token. Fixes handling of serialized signatures Changelog #4625 Merges the disposable gas payer flag into `fee_payer` Improves conflicts and requirements in cli args for `TxCustom` Merges fee payer and wrapper signature into a single field of `SigningTxData` Moves signatures and wrapper signature into `SigningTxData` Moves `signatures` and `wrapper_signature` args from `Tx` to `TxCustom` Improves cli help messages for signers/fee payers Changelog #4619 Defers saving disposable gas payer to the wallet right before tx submission Removes `--disposable-gas-payer` arg Adds warning messages for transparent fee payment in masp transaction. Adds conflict between the disposable gas payer argument and the signing keys one. Updates help message for `gas-spending-key` Mandatory source in `MaspTargetTransferData` Implied gas spending key Changelog #4579 Derive `PartialEq` for `SigningTxData` Makes the public keys for signing unique Tests expected commtiment tree in masp event test ci/can-backport: set semver baseline-root to current maint branch Changelog for #4582 Fix shielded swaps SQS queries Improve docstr fix: use correct denom calc for osmosis swaps Changelog for #4594 Delete IBC signer parsing as gov addr dead code ci: use nextest to run hardwallet e2e tests ci: use nextest to run hardwallet e2e tests changelog update hermes test/e2e: auto cleanup speculos process Changelog for #4580 Change ABI to C-unwind in vm_env when running natively test/e2e: hw-wallet-automation - try to disable speculos REST API Changelog #4566 Adds failing atomic batch fee payment integration test Filters only tx result events in integration tests Extends masp events integration test Adds masp events integration test fix core release by symlinking CONSENSUS_VERSION CI: bump maint version libs-v0.49 and apps-101.0 Refactors masp event lookup Fixed top-level comments. Changelog #4544 Masp fee payment msg in `display_batch_resp` Added a changelog entry. Allow migrations to reset the conversions for arbitrary Namada addresses. Added a changelog entry. Implemented logic to update transaction WASMs in hard-fork migration. Changelog for #4541 Improve MASP fee payment VP errors

grarco added 4 commits April 29, 2025 10:17

Implied gas spending key

8ede366

Mandatory source in MaspTargetTransferData

98c29af

Updates help message for gas-spending-key

a7ec6fa

Adds warning messages for transparent fee payment in masp transaction…

17417d4

…. Adds conflict between the disposable gas payer argument and the signing keys one.

grarco added a commit that referenced this pull request Apr 30, 2025

Changelog #4619

b650370

grarco force-pushed the grarco/masp-fees-ux branch from 6009df7 to b650370 Compare April 30, 2025 08:40

grarco marked this pull request as ready for review April 30, 2025 08:40

github-actions bot added the breaking:api public API breaking change label Apr 30, 2025

grarco mentioned this pull request Apr 30, 2025

Update fee docs namada-net/namada-docs#443

Merged

grarco added a commit that referenced this pull request Apr 30, 2025

Changelog #4619

bff830a

grarco force-pushed the grarco/masp-fees-ux branch from b650370 to bff830a Compare April 30, 2025 10:24

grarco added cli gas UX SDK breaking:SDK SDK breaking change labels Apr 30, 2025

grarco requested a review from sug0 April 30, 2025 11:34

grarco added 3 commits April 30, 2025 14:56

Removes --disposable-gas-payer arg

c67848e

Defers saving disposable gas payer to the wallet right before tx subm…

b709c49

…ission

Changelog #4619

e003b6a

grarco force-pushed the grarco/masp-fees-ux branch from bff830a to e003b6a Compare April 30, 2025 12:57

Improves cli help messages for signers/fee payers

a0cfbc8

This was referenced May 2, 2025

Allow paying shielded transfer with shielded or transp balance namada-net/namada-interface#1642

Open

Rework signature args #4625

Merged

sug0 approved these changes May 13, 2025

View reviewed changes

brentstone self-requested a review May 22, 2025 15:43

brentstone approved these changes May 23, 2025

View reviewed changes

grarco added the merge Ready to merge - mergifyio bot will add the PR to merge queue when all checks pass label May 26, 2025

mergify bot added a commit that referenced this pull request May 26, 2025

Merge of #4619

05885d9

mergify bot mentioned this pull request May 26, 2025

merge queue: embarking main (d03e957) and #4619 together #4648

Closed

mergify bot added a commit that referenced this pull request May 26, 2025

Merge of #4619

e7199c6

mergify bot mentioned this pull request May 26, 2025

merge queue: embarking main (d03e957) and #4619 together #4649

Closed

mergify bot merged commit 71d3acc into main May 26, 2025
28 checks passed

mergify bot deleted the grarco/masp-fees-ux branch May 26, 2025 10:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve shielded fee payment UX#4619

Improve shielded fee payment UX#4619
mergify[bot] merged 8 commits intomainfrom
grarco/masp-fees-ux

grarco commented Apr 29, 2025 •

edited

Loading

Uh oh!

brentstone left a comment

Uh oh!

codecov bot commented May 26, 2025 •

edited

Loading

Uh oh!

mergify bot commented May 26, 2025

Uh oh!

mergify bot commented May 26, 2025

Uh oh!

grarco commented May 26, 2025

Uh oh!

mergify bot commented May 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

grarco commented Apr 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe your changes

Checklist before merging

Uh oh!

brentstone left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mergify bot commented May 26, 2025

Uh oh!

mergify bot commented May 26, 2025

Uh oh!

grarco commented May 26, 2025

Uh oh!

mergify bot commented May 26, 2025

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

grarco commented Apr 29, 2025 •

edited

Loading

codecov bot commented May 26, 2025 •

edited

Loading