Merged
Conversation
…. Adds conflict between the disposable gas payer argument and the signing keys one.
grarco
force-pushed
the
grarco/offline-sig-args
branch
from
bd016c2 to
73501a3
Compare
tzemanovic
reviewed
May 9, 2025
Collaborator
Author
|
@tzemanovic I've changed the |
tzemanovic
approved these changes
May 12, 2025
grarco
added
the
merge
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4625 +/- ##
============================
============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tzemanovic
added a commit
that referenced
this pull request
Jun 4, 2025
Namada libs-v0.150.0 * tag 'libs-v0.150.0': Changelog: Release libs 0.150.0 Namada libs 0.150.0 changelog: add #4666 added changelog add more tests fixes from reviews fixes from reviews test/pos: claim optimizations PoS: optimize claim rewards add pgf test add governance test pgf/governance disallow non-native transfers Changelog for #4659 Change nomenclature of transfer in/out validation fn Soft limit the number of wasm transfer targets Adds masp integration test for multi-input notes Dont construct a shielded component when the transfer data is completely transparent. Added a changelog entry. Renamed structures to increase clarity. Combined transfer inputs and outputs. Refactors extraction of fee payer from `SigingTxData` Also write epoch migrations directly into memory. Added a changelog entry. Added a changelog entry. Demonstrate accelerating epochs. Added a migration that sets the shielded reward parameters of specified tokens. Added a changelog entry. Slow down the epochs in tricky_masp_txs. Increased the usage of constants in migrations. Allow denomination to be specified separately for each token. Fixes handling of serialized signatures Changelog #4625 Merges the disposable gas payer flag into `fee_payer` Improves conflicts and requirements in cli args for `TxCustom` Merges fee payer and wrapper signature into a single field of `SigningTxData` Moves signatures and wrapper signature into `SigningTxData` Moves `signatures` and `wrapper_signature` args from `Tx` to `TxCustom` Improves cli help messages for signers/fee payers Changelog #4619 Defers saving disposable gas payer to the wallet right before tx submission Removes `--disposable-gas-payer` arg Adds warning messages for transparent fee payment in masp transaction. Adds conflict between the disposable gas payer argument and the signing keys one. Updates help message for `gas-spending-key` Mandatory source in `MaspTargetTransferData` Implied gas spending key Changelog #4579 Derive `PartialEq` for `SigningTxData` Makes the public keys for signing unique Tests expected commtiment tree in masp event test ci/can-backport: set semver baseline-root to current maint branch Changelog for #4582 Fix shielded swaps SQS queries Improve docstr fix: use correct denom calc for osmosis swaps Changelog for #4594 Delete IBC signer parsing as gov addr dead code ci: use nextest to run hardwallet e2e tests ci: use nextest to run hardwallet e2e tests changelog update hermes test/e2e: auto cleanup speculos process Changelog for #4580 Change ABI to C-unwind in vm_env when running natively test/e2e: hw-wallet-automation - try to disable speculos REST API Changelog #4566 Adds failing atomic batch fee payment integration test Filters only tx result events in integration tests Extends masp events integration test Adds masp events integration test fix core release by symlinking CONSENSUS_VERSION CI: bump maint version libs-v0.49 and apps-101.0 Refactors masp event lookup Fixed top-level comments. Changelog #4544 Masp fee payment msg in `display_batch_resp` Added a changelog entry. Allow migrations to reset the conversions for arbitrary Namada addresses. Added a changelog entry. Implemented logic to update transaction WASMs in hard-fork migration. Changelog for #4541 Improve MASP fee payment VP errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Depends-On: #4619 (diffs: https://github.com/anoma/namada/pull/4625/files/e003b6a990ce67d6545da04651f29effd81fb4db..7734ce0563c101583bd8d81a8c2f5ccd7d12e50c).
Closes #4620.
Partially addresses #3901.
Makes the
signaturesandgas-signatureargument reserved for loading a serialized transaction since they don't make sense when we want to construct a new transaction.It also reworks
SigningTxDatato contain these two arguments and improves the wrapper signer part and disposable gas payer flag by joining everything into a singlefee_payerfield.Slightly improves the conflicts and requirements of
TxCustom.Checklist before merging
breaking::labelsnamada-docsreponamada-indexerornamada-masp-indexer, a corresponding PR is opened in that repo