feat: allow EDA credential fields to link to external Secret Management Systems (SMS)#1361
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #1361 +/- ##
==========================================
+ Coverage 93.94% 94.14% +0.20%
==========================================
Files 324 335 +11
Lines 18951 19537 +586
==========================================
+ Hits 17804 18394 +590
+ Misses 1147 1143 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Alex-Izquierdo
approved these changes
Jul 21, 2025
mkanoor
approved these changes
Jul 21, 2025
Contributor
Author
|
The e2e test failure will be handled by updating the API client on the eda-qa side after this has been merged. |
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 3, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 4 new modules to the collection: - credential_input_source - credential_input_source_info - credential_test - credential_type_test [1] ansible/eda-server#1361
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 4, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 4 new modules to the collection: - credential_input_source - credential_input_source_info - credential_test - credential_type_test [1] ansible/eda-server#1361
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 5, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 4 new modules to the collection: - credential_input_source - credential_input_source_info - credential_test - credential_type_test [1] ansible/eda-server#1361
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 5, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 4 new modules to the collection: - credential_input_source - credential_input_source_info - credential_test - credential_type_test [1] ansible/eda-server#1361
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 5, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 4 new modules to the collection: - credential_input_source - credential_input_source_info - credential_test - credential_type_test [1] ansible/eda-server#1361
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 7, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 4 new modules to the collection: - credential_input_source - credential_input_source_info - credential_test - credential_type_test [1] ansible/eda-server#1361
kaiokmo
added a commit
to kaiokmo/event-driven-ansible
that referenced
this pull request
Aug 7, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 2 new modules to the collection: - credential_input_source - credential_input_source_info As a bonus feature, we also implement the "test" functionality to credential and credential_type, which essentially adds the support to reach the test credential endpoints to check if a credential is working as expected before actually creating the credential. [1] ansible/eda-server#1361
kaiokmo
added a commit
to ansible/event-driven-ansible
that referenced
this pull request
Aug 8, 2025
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 2 new modules to the collection: - credential_input_source - credential_input_source_info We also implement the "test" functionality to credential and credential_type, which essentially adds the support to reach the test credential endpoints to check if a credential is working as expected before actually creating the credential. [1] ansible/eda-server#1361 Co-authored-by: Madhu Kanoor <mkanoor@redhat.com>
mkanoor
added a commit
to mkanoor/eda-server
that referenced
this pull request
Aug 20, 2025
We missed this file when working on PR ansible#1361 https://issues.redhat.com/browse/AAP-51904
mkanoor
added a commit
that referenced
this pull request
Aug 21, 2025
We missed this file when working on PR #1361 https://issues.redhat.com/browse/AAP-51904 We are adding an ATF test to do the real integration test https://issues.redhat.com/browse/AAP-51905
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This RP is regenerated from #1349
AAP allows text fields in a Credential to be connected to an external Secret Management System like Hashicorp Vault.
EDA was lacking this feature, this fix tries to address that by providing
New API end points added
The awx-plugins-core supports 10 different external systems, for parity we have added the schema for all 10 of them
https://issues.redhat.com/browse/AAP-46900
flowchart TD; A[EDA UI] -->|Create Credential| B(EDA API); B --> C{AWX Plugins}; C -->|Fetch/Test| D[fa:fa-vault Hashicorp]; C -->|Fetch/Test| E[fa:fa-vault CyberArk]; C -->|Fetch/Text| F[fa:fa-vault Azure];