feat: [AAP-47707] allow credentials to link to external SMS#459
Merged
Conversation
Contributor
|
@kaiokmo I have two questions:
|
Member
Author
@hsong-rh that's a great point. I think it makes sense to extract the functionality of |
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others. To comply with the back-end functionality, this PR adds 2 new modules to the collection: - credential_input_source - credential_input_source_info As a bonus feature, we also implement the "test" functionality to credential and credential_type, which essentially adds the support to reach the test credential endpoints to check if a credential is working as expected before actually creating the credential. [1] ansible/eda-server#1361
hsong-rh
approved these changes
Aug 7, 2025
mkanoor
approved these changes
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/AAP-47707
Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others.
To comply with the back-end functionality, this PR adds 2 new modules to the collection:
We also implement the "test" functionality to credential and credential_type, which essentially adds support to reach the test credential endpoints to check if a credential is working as expected before actually creating the credential.
[1] ansible/eda-server#1361