Skip to content

feat: [AAP-47707] allow credentials to link to external SMS#459

Merged
kaiokmo merged 2 commits into
ansible:mainfrom
kaiokmo:AAP-47707
Aug 8, 2025
Merged

feat: [AAP-47707] allow credentials to link to external SMS#459
kaiokmo merged 2 commits into
ansible:mainfrom
kaiokmo:AAP-47707

Conversation

@kaiokmo
Copy link
Copy Markdown
Member

@kaiokmo kaiokmo commented Aug 3, 2025

https://issues.redhat.com/browse/AAP-47707

Based on eda-server PR 1361[1], now EDA allows credentials to link to external Secret Management Systems (SMS), like Hashicorp Vault and others.

To comply with the back-end functionality, this PR adds 2 new modules to the collection:

  • credential_input_source
  • credential_input_source_info

We also implement the "test" functionality to credential and credential_type, which essentially adds support to reach the test credential endpoints to check if a credential is working as expected before actually creating the credential.

[1] ansible/eda-server#1361

@kaiokmo kaiokmo added the enhancement New feature or request label Aug 3, 2025
@hsong-rh
Copy link
Copy Markdown
Contributor

hsong-rh commented Aug 5, 2025

@kaiokmo I have two questions:

  1. We have credential and credential_type modules already. Should we add the test functions there, instead of creating new modules credential_test and credential_type_test?
  2. We also need to update the main.yml of credential and credential_type for the test function, right? Like what you added for credential_input_source?

@ttuffin ttuffin requested a review from a team August 6, 2025 09:33
@kaiokmo
Copy link
Copy Markdown
Member Author

kaiokmo commented Aug 6, 2025

@kaiokmo I have two questions:

1. We have `credential` and `credential_type` modules already. Should we add the `test` functions there, instead of creating new modules `credential_test` and `credential_type_test`?

2. We also need to update the main.yml of `credential` and `credential_type` for the `test` function, right? Like what you added for `credential_input_source`?

@hsong-rh that's a great point. I think it makes sense to extract the functionality of credential_test and credential_type_test into the already existing credential and credential_type modules. I will change the modules accordingly and also the integration tests.

Based on eda-server PR 1361[1], now EDA allows credentials to link to
external Secret Management Systems (SMS), like Hashicorp Vault and
others.

To comply with the back-end functionality, this PR adds 2 new modules
to the collection:
  - credential_input_source
  - credential_input_source_info

As a bonus feature, we also implement the "test" functionality to
credential and credential_type, which essentially adds the support
to reach the test credential endpoints to check if a credential
is working as expected before actually creating the credential.

[1] ansible/eda-server#1361
@kaiokmo kaiokmo requested a review from a team August 7, 2025 18:06
@kaiokmo kaiokmo merged commit 3959ee8 into ansible:main Aug 8, 2025
18 checks passed
@github-project-automation github-project-automation Bot moved this from Review to Done in 🧰 devtools project board Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request feature

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants