Add options overload API's to Metrics Advisor Clients#3
Merged
anuchandy merged 3 commits intoMay 28, 2021
Merged
Conversation
anuchandy
requested changes
May 28, 2021
anuchandy
left a comment
anuchandy
left a comment
Owner
There was a problem hiding this comment.
LGTM, some minor comments, also be sure to run (just to catch any style validations)
mvn clean install -f sdk/metricsadvisor/pom.xml --batch-mode -Dmaven.wagon.http.pool=false --settings eng/settings.xml -DskipTests -Dinclude-template -Dgpg.skip -Dmaven.javadoc.skip=false -Dcheckstyle.skip=false -Dspotbugs.skip=false -Drevapi.skip=true| public PagedFlux<MetricSeriesDefinition> listMetricSeriesDefinitions( | ||
| String metricId, | ||
| OffsetDateTime activeSince) { | ||
| return listMetricSeriesDefinitions(metricId, activeSince); |
| @ServiceMethod(returns = ReturnType.COLLECTION) | ||
| public PagedFlux<AnomalyDetectionConfiguration> listMetricAnomalyDetectionConfigs( | ||
| String metricId) { | ||
| return listMetricAnomalyDetectionConfigs(metricId); |
| String alertId, | ||
| ListIncidentsAlertedOptions options) { | ||
| return listIncidents(alertConfigurationId, alertId, options, Context.NONE); | ||
| } |
Owner
There was a problem hiding this comment.
we need below overload
public PagedIterable<AnomalyIncident> listIncidents(String alertConfigurationId,
String alertId);| String detectionConfigurationId, | ||
| String dimensionName, | ||
| OffsetDateTime startTime, OffsetDateTime endTime) { | ||
| return listAnomalyDimensionValues(detectionConfigurationId, dimensionName, startTime, endTime); |
anuchandy
pushed a commit
that referenced
this pull request
Apr 3, 2023
* health insights sdk for java * rename country to countryOrRegion * update product name to azure-health-insights * update cspell with missing words * update root pom.xml and version_client.txt * update dependency versions * update dependency versions (#2) * skip jacoco * fix spell checks * Asaflevi/feature/healthinsights sdk for java (#3) * update dependency versions * skip jacoco * fix spell checks * skip jacoco * linting * remove redundant plugins * remove test.yaml files * remove redundant package.json file * fix sampes and readmes * spell * fix linting * fix sample repository reference * remove duplicate dependency (mockito) * alignment (readme) * fix readme title * setPlaybackSyncPollerPollInterval * update serviceversion class (emitter 0.5.1) * remove impressions png
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses API view feedback - https://apiview.dev/Assemblies/Review/562e820e03de44c293b8dd205a0ecb4c#f2090bb8cd3f4332a315b833b2176962