Add persistent volume claim retention policy#38361
Closed
nirroz93 wants to merge 3 commits into
Closed
Conversation
nirroz93
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
amoghrajesh
reviewed
Apr 16, 2024
amoghrajesh
left a comment
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
@nirroz93 good work on the PR. Few comments:
- Can we add this also to
chart/files/pod-template-file.kubernetes-helm-yamlfor K8sExecutor? - Can we add unit tests foe this under
helm_tests? Check similar tests.
| persistence: | ||
| # Enable persistent volumes | ||
| enabled: true | ||
| # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled\removed |
Contributor
There was a problem hiding this comment.
nit:
Suggested change
| # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled\removed | |
| # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled/removed |
| persistence: | ||
| # Enable persistent volumes | ||
| enabled: true | ||
| # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled\removed |
Contributor
There was a problem hiding this comment.
Suggested change
| # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled\removed | |
| # persistentVolumeClaimRetentionPolicy if statefulset is used, to determine delete when scaled/removed |
Contributor
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
Bot
added
the
stale
Contributor
no need to add this to |
Contributor
|
@nirroz93 are you actively working on this? |
jedcunningham
modified the milestones:
Airflow Helm Chart 1.14.0,
Airflow Helm Chart 1.15.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add persistentVolumeClaimRetentionPolicy available since k8s 1.23 (alpha) and 1.27 (beta). With logs, this makes a lot of sense (with remote logging only running task log is important, and on scale down pvc should be removed)