Add persistent volume claim retention policy#40271
Merged
Merged
Conversation
romsharon98
requested review from
dstandish,
hussein-awala and
jedcunningham
as code owners
eladkal
changed the title
hussein-awala
approved these changes
Jun 19, 2024
hussein-awala
left a comment
hussein-awala
left a comment
Member
There was a problem hiding this comment.
I added a small nit, otherwise LGTM
eladkal
approved these changes
Jun 19, 2024
amoghrajesh
approved these changes
Jun 20, 2024
amoghrajesh
left a comment
amoghrajesh
left a comment
Contributor
There was a problem hiding this comment.
I have a few nits, otherwise looks good @romsharon98
eladkal
force-pushed
the
retention-policy
branch
from
536cd6d to
a2afc9e
Compare
utkarsharma2
added
the
changelog:skip
romsharon98
added a commit
to romsharon98/airflow
that referenced
this pull request
Jul 26, 2024
* add persistentVolumeClaimRetentionPolicy * add new triggerer persistentVolumeClaimRetentionPolicy to values schema * add persistentVolumeClaimRetentionPolicy * revert pod-template-file * add description to values schema * add description to values.json * fix values-schema, imporove comments --------- Co-authored-by: Nir Rosenthal <nirr@perion.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #38361
Redo stale PR. Commits where cherry picked from stale PR to preserve credit to the origial author
cc: @nirroz93
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.