Enable dynamic generation of assets for Edge UI Plugin#56456
Conversation
|
I looked at things we can do, and I think the easiest thing (and also something we could also switch to in airflow-core is https://github.com/rmorshea/hatch-build-scripts. This way we wil likely be able to get rid of hatch_build.py altogether most likely and only rely on running prek to install npm and build the assets |
|
Also - as discussed - we will have to move the pre-commit config for the provider to inside of it (which is now possible with prek monorepo support) |
9055674 to
575670b
Compare
|
@potiuk as during our jogging-roud - rebase of ~1200 commits. Since then the pre-commit config has been split. Still this is the proposal but quite complex. Have any thoughts matured how to make dynamic asset building possible by other means of rework of provider packaging? |
dheerajturaga
left a comment
There was a problem hiding this comment.
@jscheffl , This looks great! however I found some blockers. Quick fix before merge?
dheerajturaga
left a comment
There was a problem hiding this comment.
Great! Updated changes look good! Thanks for fixing @jscheffl !
So far the generated UI assets for Edge Worker React Plugin were manually compiled and checked-in the repo. This is a bit slowing down parallel development as the generated assets always generate merge conflicts and checking in compiled/generated code in general is not good.
This PR changes the way for Edge to compile React UI assets when
breeze start-airflowas well as when Wheel/Sdist is packaged.This is WIP/Draft to have an early review. Especially looking forward for review by @potiuk as within this PR we need to enable building providers with hatchling selectively which has an impact on reproducible builds and CI ecosystem.
before completion:
A follow-up of this PR would be apply the same to FAB provider and Fab UI.