Skip to content

Run hatch always in a clean env#61970

Merged
dheerajturaga merged 2 commits into
apache:mainfrom
jscheffl:bugfix/run-hatch-in-clean-env
Feb 16, 2026
Merged

Run hatch always in a clean env#61970
dheerajturaga merged 2 commits into
apache:mainfrom
jscheffl:bugfix/run-hatch-in-clean-env

Conversation

@jscheffl
Copy link
Copy Markdown
Contributor

@jscheffl jscheffl commented Feb 15, 2026 •
edited
Loading

In PR #56456 @dheerajturaga detected that hatch was always executed in a env as copy... and changed to a clean env - now as consistency this PR changes the calls to "hatch" in all other cases in the repo.

Note that the PATH also needs to be added to be able that hatch can find prek.

Made a run with main and diffoscope of same changes of this PR. Only diff I was was packaged GIT hash and resulting diffs in CRC and ZIP structures.

Was generative AI tooling used to co-author this PR?
  • No (please specify the tool below)
  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

@jscheffl jscheffl added full tests needed We need to run full set of tests for this PR to merge all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs labels Feb 15, 2026
@jscheffl jscheffl marked this pull request as ready for review February 15, 2026 22:50
@potiuk
Copy link
Copy Markdown
Member

potiuk commented Feb 15, 2026

Cool :)

dheerajturaga
dheerajturaga approved these changes Feb 16, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@dheerajturaga dheerajturaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Nice and consistent

@dheerajturaga dheerajturaga merged commit 736c262 into apache:main Feb 16, 2026
325 of 336 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
❌ v3-1-test Commit Link

You can attempt to backport this manually by running:

cherry_picker 736c262 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

If you don't have cherry-picker installed, see the installation guide.

@jscheffl
Copy link
Copy Markdown
Contributor Author

jscheffl commented Feb 16, 2026

Hi @dheerajturaga thanks for merging! Not sure if you have seen as a new committer, if you merge something on main you need to take care that if backport needed it is back-ported to 3.1 or whatever needed branch according to https://github.com/apache/airflow/blob/main/dev/README_AIRFLOW3_DEV.md - or you should make a note if it should not apply. Let me know if I'd make it but we agreed (before you were contributor though :-D) that the one merging is taking care of.

@dheerajturaga
Copy link
Copy Markdown
Member

dheerajturaga commented Feb 16, 2026

@jscheffl Ah! I missed this. Would you be able to take care of this one?

jscheffl added a commit to jscheffl/airflow that referenced this pull request Feb 16, 2026
@jscheffl
[v3-1-test] Run hatch always in a clean env (apache#61970)
0cdb847 
* Run hatch always in a clean env

* Add PATH to env
(cherry picked from commit 736c262)

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
potiuk pushed a commit that referenced this pull request Feb 16, 2026
@jscheffl
[v3-1-test] Run hatch always in a clean env (#61970) (#62051)
f8c6493 
* Run hatch always in a clean env

* Add PATH to env
(cherry picked from commit 736c262)
choo121600 pushed a commit to choo121600/airflow that referenced this pull request Feb 22, 2026
@jscheffl @choo121600
Run hatch always in a clean env (apache#61970)
a3a195d 
* Run hatch always in a clean env

* Add PATH to env
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
@jscheffl @Subham-KRLX
Run hatch always in a clean env (apache#61970)
969f794 
* Run hatch always in a clean env

* Add PATH to env
vatsrahul1001 pushed a commit that referenced this pull request Mar 4, 2026
@jscheffl @vatsrahul1001
[v3-1-test] Run hatch always in a clean env (#61970) (#62051)
dafc988 
* Run hatch always in a clean env

* Add PATH to env
(cherry picked from commit 736c262)
dominikhei pushed a commit to dominikhei/airflow that referenced this pull request Mar 11, 2026
@jscheffl @dominikhei
Run hatch always in a clean env (apache#61970)
52578ec 
* Run hatch always in a clean env

* Add PATH to env
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
@jscheffl @Ankurdeewan
Run hatch always in a clean env (apache#61970)
e728590 
* Run hatch always in a clean env

* Add PATH to env
radhwene pushed a commit to radhwene/airflow that referenced this pull request Mar 21, 2026
@jscheffl
Run hatch always in a clean env (apache#61970)
c7624b6 
* Run hatch always in a clean env

* Add PATH to env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@potiuk potiuk potiuk approved these changes

@gopidesupavan gopidesupavan gopidesupavan approved these changes

@dheerajturaga dheerajturaga dheerajturaga approved these changes

@ashb ashb Awaiting requested review from ashb ashb is a code owner

@amoghrajesh amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

@bugraoz93 bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

@kaxil kaxil Awaiting requested review from kaxil

@jason810496 jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

@jedcunningham jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

@ephraimbuddy ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

Assignees

No one assigned

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:dev-tools full tests needed We need to run full set of tests for this PR to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jscheffl @potiuk @dheerajturaga @gopidesupavan