Fix OTel integration test for new task.execute detail span#69237
Closed
potiuk wants to merge 1 commit into
Closed
Conversation
apache#67877 added a task.execute detail span around the task execute callable at task span detail level > 1, so operator-emitted spans (such as sub_span1) now nest under it instead of directly under _execute_task. That PR did not update the OTel integration test's expected span hierarchy, and because the OTel integration suite runs only on schedule/canary rather than per-PR, the change merged green and test_dag_execution_succeeds[detail_spans] has been failing on main since. Update the expected hierarchy to include the task.execute span.
Member
Author
|
Close in favour of #69236 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_dag_execution_succeeds[detail_spans]has been failing on main'sscheduled/canary runs, e.g.
https://github.com/apache/airflow/actions/runs/28562105904
Root cause: #67877 ("Add task.execute detail span around task execute callable")
wraps the execute callable in its own
task.executespan at task span detaillevel > 1, so operator-emitted spans nest under
task.executerather thandirectly under
_execute_task. The OTel integration test's expected hierarchywas not updated in that PR — and since the OTel integration suite only runs on
schedule/canary (not per-PR), it merged without catching the break.
Update the
detail_spansexpected hierarchy to include thetask.executespan(
sub_span1->task.execute->_execute_task), matching the actual output.Only the
detail_spansvariant is affected;default_spans(detail level <= 1)is unchanged.
related: #67877
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8 1M) following the guidelines