Fix OTel integration test after task.execute span addition#69236
Conversation
PR apache#67877 wrapped the operator execute callable in a new task.execute detail span, so operator-emitted spans now nest under it instead of directly under _execute_task. Integration tests do not run on regular PRs, so the expected span hierarchy in the OTel integration test was not updated there and the canary build started failing.
|
My agent also suggested to harden the test harness:
|
|
Hi maintainer, this PR was merged without a milestone set.
|
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
This make sense to me as well, but I will merge this now to make main green, please feel free to raise follow-up for the test hardening. I will fix from the selective check side first, that we should trigger the otel integration test whenever the task-sdk |
apache#69236) PR apache#67877 wrapped the operator execute callable in a new task.execute detail span, so operator-emitted spans now nest under it instead of directly under _execute_task. Integration tests do not run on regular PRs, so the expected span hierarchy in the OTel integration test was not updated there and the canary build started failing. (cherry picked from commit 55cdf67) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
apache#69236) PR apache#67877 wrapped the operator execute callable in a new task.execute detail span, so operator-emitted spans now nest under it instead of directly under _execute_task. Integration tests do not run on regular PRs, so the expected span hierarchy in the OTel integration test was not updated there and the canary build started failing. (cherry picked from commit 55cdf67) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
#69236) PR #67877 wrapped the operator execute callable in a new task.execute detail span, so operator-emitted spans now nest under it instead of directly under _execute_task. Integration tests do not run on regular PRs, so the expected span hierarchy in the OTel integration test was not updated there and the canary build started failing. (cherry picked from commit 55cdf67) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
logging_config_classcontract and documentREMOTE_TASK_LOG#67104.Why
#67877 wrapped the operator execute callable in a new
task.executedetail span, so operator-emitted spans now nest under it instead of directly under_execute_task. Integration tests do not run on regular PRs, so the expected span hierarchy in the OTel integration test was not updated and the canary build started failing ontest_dag_execution_succeeds[detail_spans].What
task.execute(child of_execute_task) to the expected span hierarchy of thedetail_spanscase.sub_span1from_execute_tasktotask.execute, matching what the runtime actually emits.Verified with
breeze testing core-integration-tests --integration otel --backend postgres: all 5 OTel integration tests pass.Was generative AI tooling used to co-author this PR?